angular-evaporate icon indicating copy to clipboard operation
angular-evaporate copied to clipboard

Unresponsive Script - large inputs

Open Masterdanielsan opened this issue 8 years ago • 7 comments

When adding large file inputs, I am seeing the browser get locked up and throw an 'unresponsive script' popup.

Seems to do this on FireFox consistently, but I'm not seeing it happen on Chrome.

Please confirm bug.

Masterdanielsan avatar Oct 13 '16 23:10 Masterdanielsan

How large? Only number of files counts or their sizes too? I need to reproduce it to confirm and fix)

uqee avatar Oct 14 '16 09:10 uqee

I am loading around 2000-3000 files around 20GB-40GB total upload range.

I'm getting a lot of issues with this right now. Non Responsive Script in FF, and I've seen a few crashes and 'out of memory' issues. If you could help stress it and find out the issue, I would be appreciative.

AE seems to be hogging resources pretty bad at the moment... at least in my implementation of it.

Masterdanielsan avatar Oct 14 '16 17:10 Masterdanielsan

ff_memory

I'm not sure if this is connected, but I'm trying to upload 2045 files (total of 19.1 GiB) and this is what my browser memory is at 6.8% in...

This is worrysome! I don't know if it's evaporatejs, angular-evaporate, or impimentations thereof on my part.

----EDIT----

I had another page running that was interfering with the memory for that snapshot, but I think i'm still seeing spikes in memory usage on loading images. I'll continue to test.

Masterdanielsan avatar Oct 14 '16 17:10 Masterdanielsan

Whoa, that's huge. Would you checkout a fix/large-files branch to try some ideas if I commit them here?

uqee avatar Oct 14 '16 21:10 uqee

Current version of this branch adds just one file at a time (as opposed to using a loop to add all of them at once). Can probably resolve UI hanging issues when large number of files added, try it.

uqee avatar Oct 14 '16 21:10 uqee

Hmm, this seems to 'solve' the issue of hanging, but maybe using async or something, we could do this a bit faster by adding multiple at a time? I can add a spinner while this happens, but it's not exactly optimized. :/

Masterdanielsan avatar Oct 17 '16 17:10 Masterdanielsan

It would also be good to fire an event when this is done loading.

Masterdanielsan avatar Oct 17 '16 17:10 Masterdanielsan