pkgnet icon indicating copy to clipboard operation
pkgnet copied to clipboard

allow coloring of function nodes based on the script they came from

Open bburns632 opened this issue 7 years ago • 6 comments

This should be a byproduct of the covr::tally_coverage function in PR #24 . However, I believe these fields are being dropped before populating the nodes table. We should attach them as well

bburns632 avatar Dec 20 '17 01:12 bburns632

PR #24 added source script column during coverage testing, so it's available for this purpose. This just needs a way to enable this option.

bburns632 avatar Dec 27 '17 19:12 bburns632

PR #40 re-enables this. But again, this is not an option yet surfaced to a user.

bburns632 avatar Jan 26 '18 06:01 bburns632

Related to #132. If we are going to add clickable options in the HTML report to adjust the graphic, we should include this as an option as well.

bburns632 avatar Nov 30 '18 14:11 bburns632

One of the problems is that I think that viznetwork only lets you color nodes one way at a time. So you can't simultaneously color part of a node with coverage and another part of it with some script identification color.

AFAIK I don't think viznetwork lets you toggle options like this.

jayqi avatar Nov 30 '18 19:11 jayqi

I think we might be able to add some custom stuff using the methodology described here. https://deanattali.com/blog/htmlwidgets-tips/#custom-html

Some of my ideas around what we can do are:

  • Toggles to change when clicking a node, whether the in-subgraph, out-subgraph, or full subgraph is highlighted.
  • Toggles to change the node coloring

This seems like a significant change though, and we could probably use some htmlwidgets expertise help.

jayqi avatar Dec 19 '18 03:12 jayqi

This idea is being staged for the next release (v.0.5.0) temporarily. The goal and scope of v0.5.0 is being discussed in #208.

bburns632 avatar Apr 01 '19 03:04 bburns632