autofocus icon indicating copy to clipboard operation
autofocus copied to clipboard
verified publisher icon uptake

Predict app

Open DigitalPhilosopher opened this issue 6 years ago • 4 comments

Feel free to open a PR before all of these items have been completed.

Pull Request Checklist

  • [ ] Pull request includes a description of the change and the reason behind it.
  • [ ] Pull request uses keywords to close relevant issues.
  • [ ] Pull request includes unit tests for any new functionality.
  • [ ] README and docs have been updated.
  • [ ] ./.ci/local_checks.sh passes locally. (The app must be running. See README.md for instructions.)

Maintainer's responsibilities:

  • [ ] _version.py has been updated.
  • [ ] CHANGELOG.md has been updated.
  • [ ] Updated app container has been pushed, if relevant, with current version number.
  • [ ] App container version number has been updated in README.

DigitalPhilosopher avatar Oct 16 '19 08:10 DigitalPhilosopher

Got it, thanks! Will review at my earliest opportunity.

gsganden avatar Oct 16 '19 13:10 gsganden

Hey @gsganden, is there anything else you would change in my PR? I would be very happy with some advice and comments on my changes. Thanks very much :)

DigitalPhilosopher avatar Oct 22 '19 18:10 DigitalPhilosopher

It might take me a little while, but I will get to it!

gsganden avatar Oct 22 '19 19:10 gsganden

Hey @gsganden I revisited the code and made it more functional and removed most of the object orientation.

However, I kept the File (now TemporaryFile) and ZipArchive as classes, as said before. If you really don't favor this approach, I would be willing to change it as well, but I think it adds a lot to the simplicity of the code and would favor to keep it. What do you think?

DigitalPhilosopher avatar Nov 05 '19 13:11 DigitalPhilosopher