ratelimit-js icon indicating copy to clipboard operation
ratelimit-js copied to clipboard

blockUntilReady and cf workers

Open bkniffler opened this issue 1 year ago • 6 comments

blockUntilReady relies on Date.now, but in cf worker env, Date.now does not reliably progress as in nodeJS or browser env.

https://developers.cloudflare.com/workers/runtime-apis/web-standards/

Maybe this could get added to docs, it might safe a few people from headaches. Bildschirmfoto 2023-11-20 um 15 23 04

bkniffler avatar Nov 20 '23 14:11 bkniffler

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Dec 21 '23 01:12 github-actions[bot]

bump

ogzhanolguncu avatar Jan 17 '24 07:01 ogzhanolguncu

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Feb 18 '24 01:02 github-actions[bot]

Is this going to be addressed eventually? This is a serious concern that most users will probably not be aware of.

bkniffler avatar Mar 16 '24 21:03 bkniffler

We’ll see what we can do and if we can’t find a good solution, we’ll document in our docs. Sorry for late reply.

ogzhanolguncu avatar Mar 16 '24 21:03 ogzhanolguncu

Issue is finally addressed here in the docs: https://github.com/upstash/docs/pull/121

ogzhanolguncu avatar Mar 18 '24 10:03 ogzhanolguncu

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Apr 18 '24 01:04 github-actions[bot]

This issue was closed because it has been stalled for 30 days with no activity.

github-actions[bot] avatar May 18 '24 01:05 github-actions[bot]