Tobias Ribizel comments

Results 326 comments of


                                            Tobias Ribizel

add synchronization log event

This looks like it is only useful for `profiler_hook` loggers that don't distinguish between CPU and GPU timing, i.e. only the `summary` and `nested_summary` loggers, right? I'm not sure yet...

add synchronization log event

Let me be a bit more precise: The noise is the biggest issue to me. If the executor doesn't do anything when synchronizing, it also shouldn't show up in the...

1912/2 use new json input

I will take a look at this later, but let me just say it's exciting to see such reductions in code complexity :)

OpenMP test link failed

It seems like the link line for libginkgo_omp might be missing libgomp, can you maybe send us the CMakeCache.txt file and the output from a fresh CMake build with verbose...

Add minimum iteration stopping criterion wrapper

I think the config setup should ideally happen in a subsequent PR, as I'm not that familiar with it, and don't have much time to continue working on this

Should we handle zero-size matirx/vector normally?

This was always an error, and we added checks for most of those cases (cuda-memcheck also used to fail for that reason)