chartjs-chart-venn icon indicating copy to clipboard operation
chartjs-chart-venn copied to clipboard

Published 20 hours ago • verified publisher icon upsetjs

Customizable intersection labels

Open fengelniederhammer opened this issue 2 months ago • 0 comments

It would be great if we could customize the intersection labels. Specifically, we would like to get rid of thousands separator.

I've had a look into the code, the format seems to be "hardcoded" to toLocaleString, which separates by . or ,, depending on browser settings. https://github.com/upsetjs/chartjs-chart-venn/blob/774ded0ec4133ebf8bec2890ea314df288703269/src/controllers/VennDiagramController.ts#L182

ChartJS' TickOptions offer callback property: https://github.com/chartjs/Chart.js/blob/57b5c5b78fb2d8504f556bef6e4177735d9929ea/src/types/index.d.ts#L3044-L3047

Would it be possible to implement that the Venn diagrams respect this property and apply it, if set? Many other types of diagrams support that option and we already make great use of it.

User story

Additional context

We have diagrams like these: grafik

fengelniederhammer avatar Dec 05 '24 13:12 fengelniederhammer