upscayl icon indicating copy to clipboard operation
upscayl copied to clipboard

Display path for current image and output folder

Open ralacerda opened this issue 1 year ago • 2 comments

There should be some indication to the current image path and the current output folder. User would have a easier time checking if they are upscaling the right file and if the output folder changed from the default output path.

Here is a suggestion on how to do it.

Fast mockup

I would love to contribute with a Pull Request. The only problem with my current solution is long paths.

ralacerda avatar Aug 24 '22 15:08 ralacerda

The only problem with my current solution is long paths.

Yep, this is why I never added the paths in. Also because the image is visible on the right pane anyway, so having a verbose path would not really make much difference.

I'll think about it though, maybe use a truncate class or something.

NayamAmarshe avatar Aug 24 '22 15:08 NayamAmarshe

One possibility could be to show the file and folder names, rather than the whole path. Maybe something like Input Image: to_upscale.jpeg and Output Location: Pictures/.

cachandlerdev avatar Aug 24 '22 16:08 cachandlerdev

Thanks for considering my idea.

Yep, this is why I never added the paths in. Also because the image is visible on the right pane anyway, so having a verbose path would not really make much difference.

I agree that having the path for input image might be redundant

I'll think about it though, maybe use a truncate class or something.

Yeah, truncating was my first thought. The problem is that the most important information is probably at the end, that would end up being truncated. So my next idea was to try to break the line after every "/", but that would take a lot of vertical space.

So maybe using both ideas can work. We add a <wbr /> tag after every "/", this way we have a line break at the best position, we keep the minimal amount of vertical space needed, and we also add the truncate class to deal with a folder with a really long name.

Here is what it looks like:

Screenshot_20220901_154543 Screenshot_20220901_154556 Screenshot_20220901_154607

On the upside, if eventually the button sets the output image with a custom name, the UI is already in place and working.

ralacerda avatar Sep 01 '22 18:09 ralacerda

I have an even better implementation done :) The next version will use tooltips to show full paths.

NayamAmarshe avatar Sep 01 '22 19:09 NayamAmarshe