upptime icon indicating copy to clipboard operation
upptime copied to clipboard

Update client.f812e05e.js

Open v4lerio opened this issue 4 years ago • 6 comments

this hot-fix solves:

  • resolves upptime/upptime/issues/347
  • resolves upptime/upptime/issues/346

v4lerio avatar May 02 '21 16:05 v4lerio

Can you tell me more about what you've changed?

AnandChowdhary avatar May 02 '21 17:05 AnandChowdhary

@AnandChowdhary the bit that broke the UI was one of e.parentNode.removeChild(e)

Unfortunately, as the file is minified I cannot mention the specific line as it is one. Anyway, there are two occurrences, I changed the second one into e.parentNode&&e.parentNode.removeChild(e)

Not an elegant solution, only a quick fix. This should be solved into the client code not the minified bundle.

v4lerio avatar May 03 '21 00:05 v4lerio

It's kinda funny but it helped me. But of course it's not real fix because it will be overwritten with next codegen. I hope author will find the root cause

asm0dey avatar May 03 '21 08:05 asm0dey

Hi y'all! Can we either merge this fix or find the right solution? Seems there is still an issue related to this: #418

mrz1836 avatar Aug 10 '21 15:08 mrz1836

Awesome that this PR was made, but if you can tell me which part of the code you changed, I can guide you on how to update the source file directly instead of updating the generated dist file.

AnandChowdhary avatar Sep 04 '22 16:09 AnandChowdhary

@v4lerio, did you have a chance to look at my comment? Thanks! :)

AnandChowdhary avatar Sep 10 '22 13:09 AnandChowdhary