Uptime, response time graph links misformatted

[jamesylgan]

Describe the bug Links get created as https://https//

To Reproduce Steps to reproduce the behavior:

See here: https://github.com/chain-courses/exchanges/commit/f082911da37dc1fda171ba3db465bd4adbcdde35?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Expected behavior A non-broken link

Additional Info I followed the instructions, ended up with this. It seems a bit strange, not sure what went wrong but figure that it's an easy fix from the dev side where you might be more familiar with the code that creates these links :) Might be user error - in which case I might suggest revising the instructions for how to set up the .upptimerc.yml file!

EDIT: I think this might be related to using a full URL (incl https) in the cname line of the yml file. Maybe parsing that out, or providing docs to clarify would help?

This issue seems to have broken the repo - it caused the graph directory to be missing, which causes the setup CI breaks. Whoops.

[AnandChowdhary]

Yes, it's most likely due to the CNAME, which should only have the hostname, not the protocol. I'll have a closer look soon!

[jamesylgan]

The follow-up issue I faced:

Setup CI Update Template step

Run upptime/[email protected]
Removed legacy .github/workflows
Added new .github/workflows
Removed template files
Removed old data from api
ERROR [Error: ENOENT: no such file or directory, scandir 'graphs'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: 'graphs'
}
Error: ENOENT: no such file or directory, scandir 'graphs'

And some residual broken links - getting auto-routed to an error page with the messed up URL format, etc. These seem to be fixed with a re-run of the static site CI, but there was some residual stuff (link from repo to website) that had to be manually fixed and CIs re-run.

[jamesylgan]

Great project BTW! As soon as I saw it I wanted to set it up and play with it 👍

[almaashy-99]

Mohammed alrashdi