bond icon indicating copy to clipboard operation
bond copied to clipboard

Published 20 hours ago • verified publisher icon upper

Refactor tests

Open xiam opened this issue 5 years ago • 4 comments

  • move tests under internal/tests
  • use docker-compose to spin up a server and run tests

xiam avatar Feb 18 '20 22:02 xiam

Hello @pkieltyka,

What do you think about moving tests to a directory?

xiam avatar Feb 19 '20 05:02 xiam

Neat to see some clean up here :) By putting into internal folder, does that change go.mod behaviour I wonder? Looks good either way though

pkieltyka avatar Feb 19 '20 13:02 pkieltyka

I think it doesn’t because they’re only tests. But that’s important and it's worth a try.

On Wed 19 Feb 2020 at 7:25 Peter Kieltyka [email protected] wrote:

Neat to see some clean up here :) By putting into internal folder, does that change go.mod behaviour I wonder? Looks good either way though

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/upper/bond/pull/34?email_source=notifications&email_token=AAC6FBXEE3Q4REQQRSPGJYLRDUXLJA5CNFSM4KXNLBKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMH2JII#issuecomment-588227745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC6FBRWN6Y4UPC4ZSWORL3RDUXLJANCNFSM4KXNLBKA .

xiam avatar Feb 19 '20 13:02 xiam

I tried this out with https://github.com/upper/bond-example-project and didn't find anything odd with the directory change. I simulated a v0.11.0 tag.

xiam avatar Feb 19 '20 21:02 xiam