uport-mobile icon indicating copy to clipboard operation
uport-mobile copied to clipboard

Custom Caleuche Support

Open ajunge opened this issue 6 years ago • 29 comments

Motivation: Right now the mobile app only allows to backup to uport hosted caleuche service at https://api.uport.me/caleuche. Some users want to run their own instance of caleuche, so we need a way on the mobile app to add the custom caleuche URL and start backing up there.

Work needed: We need to add a screen on the "Account Back Up" option, that allows the user to add a custom URL for their own instance of caleuche. Also need to change the functionality to use the new url ( https://github.com/uport-project/uport-mobile/blob/02db5e6f5d70073b8f982eda4946b071caa4315f/lib/sagas/hubSaga.js ). If the user is changing from any backup service, the new service needs to be updated with the latest data.

Acceptance criteria: A runnable version of the mobile app (based out of develop branch) that allows to change the backup server and migrate all the already backed up data to the new service.

Please feel free to ask any question in case something is not well explained

ajunge avatar Nov 19 '18 18:11 ajunge

To run your own instance of caleuche: https://github.com/uport-project/lambda-caleuche/blob/develop/RUN_INSTANCE.md

ajunge avatar Nov 19 '18 18:11 ajunge

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 250.0 DAI (250.0 USD @ $1.0/DAI) attached to it as part of the ConsenSys / uPort fund.

gitcoinbot avatar Nov 19 '18 19:11 gitcoinbot

I'll give it a shot. Not too confident about the UI, but it might work out!

tpscrpt avatar Nov 19 '18 20:11 tpscrpt

Let us know if you run into any problems

ajunge avatar Nov 19 '18 20:11 ajunge

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 weeks, 6 days ago. Please review their action plans below:

1) jamesdigid has been approved to start work.

First I'll look over the existing "Account Backup Option," and get familiar with the current functionality. I'll need to review data manipulation functionality already written, along with network service operations, and any REST API's to understand the flow on how data is backed up already. After on-boarding i'll build out the functionality such that a custom url is entered and data is either both backed up and/or migrated there.

Learn more on the Gitcoin Issue Details page.

2) ramanandapanda has been approved to start work.

I would like to work on it. I have worked on react native. what are the initial steps to setup the dev env? Please guide. I cannot clone git clone [email protected]:uport-project/lambda-caleuche.git getting permission denied.

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Nov 20 '18 06:11 gitcoinbot

I cannot clone git clone [email protected]:uport-project/lambda-caleuche.git getting permission denied.

Weird. Is public repo. Trying to reproduce it

ajunge avatar Nov 20 '18 12:11 ajunge

It's my understanding that we do require public key auth on most of our repos -- if there is no ssh key on your github account, it won't let you push/pull/clone

rmw2 avatar Nov 20 '18 13:11 rmw2

@ajunge --I had some questions about the custom url they would be inputting. Such as do you plan to support mostly AWS storage services like s3, or others such as ftp, sftp, etc. --

Just finished setting up the lambda-caleuche i was misunderstanding what the custom url was.

Thanks

jamesdigid avatar Nov 20 '18 18:11 jamesdigid

@jamesdigid You can work on your solution too. We don't know if the other person will finish, and if both come out with a solution then we can find a way make everyone happy. The customUrl is always an https://...... caleuche instance. If not, is an invalid url. In the future we expect to write more storage modules for caleuche to provide more alternatives to our users.

ajunge avatar Nov 20 '18 20:11 ajunge

@ajunge So just to clarify you want this feature built off of develop branch? I'm running into a few issues with the delete functionality and just want make sure that develop is stable enough to work off of? Because i'm getting inconsistent results. Originally the develop branch had a functional account backup with delete. Now i seem to be stuck in a delete state.

I've followed through the logic and found the saga flow handling this, it seems to be returning a 500 error with: "index.map is not a function" as the error message. I found this also exist on my local fork'ed copy but still hitting same api end point. Is there any reason we aren't branching from master for the pull request?

jamesdigid avatar Nov 21 '18 02:11 jamesdigid

@jamesdigid we branch from develop and make pull requests back there. Master is the release branch. I looked into your issue and it appear that doing a backup with remote debugger on corrupts the backup so it can't be deleted. Rebuild new app and try without remote debug?

jasheal avatar Nov 21 '18 13:11 jasheal

@ramanandapanda Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Nov 23 '18 17:11 gitcoinbot

@jamesdigid Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Nov 26 '18 17:11 gitcoinbot

@ramanandapanda Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Nov 26 '18 17:11 gitcoinbot

where to store the url, in the device (asyncstorage)? or other way?

ocio28 avatar Nov 28 '18 22:11 ocio28

I think is stored on the redux state. But I prefer confirmation from @rmw2

ajunge avatar Nov 28 '18 22:11 ajunge

@ajunge Commenting to back, to say restarting work on this issue.

jamesdigid avatar Nov 29 '18 03:11 jamesdigid

@jasonhealy I attempted to delete with live debug turned off, is there any other local cache that I should know to get back to a working state?

jamesdigid avatar Nov 29 '18 03:11 jamesdigid

@jamesdigid Delete the app from device/simulator and rebuild. Save the url to the settings key in redux which gets persisted.

jasheal avatar Nov 29 '18 11:11 jasheal

i try to configure a caleuche instance following the instructions but the encrypt command do nothing (no error, no file change)

sls encrypt -n SECRETS:BUCKET -v caleuche -k 93589337-f911-4379-983d-694...

ocio28 avatar Nov 29 '18 17:11 ocio28

@ramanandapanda Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Nov 29 '18 17:11 gitcoinbot

@jamesdigid Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Dec 02 '18 17:12 gitcoinbot

@ramanandapanda Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Dec 02 '18 17:12 gitcoinbot

@jamesdigid Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Commenting to say I submitted pull request for this feature. Let me know if this works.

jamesdigid avatar Dec 03 '18 17:12 jamesdigid

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 250.0 DAI (250.0 USD @ $1.0/DAI) has been submitted by:

  1. @jamesdigid

@ajunge please take a look at the submitted work:

  • PR by @jamesdigid

gitcoinbot avatar Dec 03 '18 21:12 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 250.0 DAI (250.0 USD @ $1.0/DAI) has been submitted by:

  1. @jamesdigid

@ajunge please take a look at the submitted work:

  • PR by @jamesdigid

gitcoinbot avatar Dec 04 '18 01:12 gitcoinbot

Hey @ajunge ! Have you had the chance to take a look at the submitted work yet?

CPSTL avatar Dec 10 '18 02:12 CPSTL

@jamesdigid did you see the review comment on the PR https://github.com/uport-project/uport-mobile/pull/38 ?

ajunge avatar Dec 12 '18 17:12 ajunge

@ajunge Yes, I spent time developing this solution and made mention of a previously existing issue and was still denied my bounty... This is a waste of time if you're QA people are not willing to actually test my PR.

jamesdigid avatar Feb 15 '19 19:02 jamesdigid