uport-connect icon indicating copy to clipboard operation
uport-connect copied to clipboard

Document returned from `connect.requestDisclosure()` does not look like a full DID doc

Open mi-xu opened this issue 6 years ago • 1 comments

Calling connect.requestDisclosure() results in a payload that looks like this:

{
  "data": undefined
  "id": "disclosureReq",
  "res": {
    "boxPub": undefined,
    "did": "did:uport: 2ofYLA3MayP4cMnr6fVHEzpvyckkUMwaqZ3",
  }
}
  • Should data and res.boxPub be undefined? If so, can we just omit them from the response?
  • It is my understanding that the res should be a DID document, but that doesn't seem to be the case. Is this just because I'm using a legacy mnid identity? If the response from this function is not supposed to be the DID doc, what function is supposed to return that, or is it meant to be abstracted away from the user by the uPort infrastructure?

Code sandbox example: Edit uPort Connect Example

mi-xu avatar Aug 24 '18 20:08 mi-xu

Could be the legacy identity -- does this happen with an ethr-did?

But either way we should fix this

rmw2 avatar Oct 23 '18 19:10 rmw2