modali

modali copied to clipboard

Bumps [acorn](https://github.com/acornjs/acorn) from 6.1.1 to 6.4.1. Commits 9a2e9b6 Mark version 6.4.1 90a9548 More rigorously check surrogate pairs in regexp validator df0cf1a Mark version 6.4.0 5303412 Also export Parser via Parser.acorn...

dependabot[bot]

Currently `toggle` function is created anew on each render. If later passed as a prop to a component it can cause unnecessary rerenders. Memoizing `toggle` with `useCallback` would avoid that

Velenir

separate display from logic

1

I like the approach here and I appreciate all the aria things, but I think the current styling approach is a bit heavy-handed. How about separating the styling into the...

wmertens

I just want to hide the close button, but not the title.

miliu99

Does Modal have any features for Focus trapping or have a known solution with one of the other focus traps out there?

jayshepherd

baptisteArno

Cant scroll

1

If I have elements beyond modal, I cant scroll to see.

RahulJanagouda

Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. Commits - [`754f0c2`](https://github.com/jonschlinkert/mixin-deep/commit/754f0c20e1bc13ea5a21a64fbc7d6ba5f7b359b9) 1.3.2 - [`90ee1fa`](https://github.com/jonschlinkert/mixin-deep/commit/90ee1fab375fccfd9b926df718243339b4976d50) ensure keys are valid when mixing in values - See full diff in [compare view](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2) Maintainer changes This...

dependabot[bot]

Add TypeScript types

5

I'm using these for now, if anyone wants to build off this: `modali.d.ts` ```ts declare module 'modali' { export interface IModalProps { isShown: boolean hide: () => void options: IModalOptions...

coffenbacher

Modali uses shortid & nanoid at the same time

2

Hello! That lib looks really promising, so thank you! I found an issue exploring modali with [bundlephobia](https://bundlephobia.com/[email protected]). From bundlephobia stats, it turns that modali uses `shortid` & `nanoid` in the...

jaxxreal