modali
modali copied to clipboard
react-syntax-highlighter
Looks to me like you could remove the react-syntax-highlighter dependency. Oh - I see references to it in the examples but shouldn't it not be in the npm release package?
I agree with this, react-syntax-highlighter has some additional dependencies, and even if this is not included in the bundle it adds complexity and possibly unnecessary security warnings from NPM. Could we move react-syntax-highlighter to devDependencies?
This is the dependency tree for react-syntax-highlighter:
$ npx npm-remote-ls react-syntax-highlighter --development=false
└─ [email protected]
├─ @babel/[email protected]
│ └─ [email protected]
├─ [email protected]
│ └─ [email protected]
│ ├─ [email protected]
│ ├─ [email protected]
│ │ └─ [email protected]
│ └─ [email protected]
├─ [email protected]
│ ├─ [email protected]
│ │ └─ [email protected]
│ └─ [email protected]
├─ [email protected]
│ ├─ [email protected]
│ ├─ [email protected]
│ │ ├─ [email protected]
│ │ ├─ [email protected]
│ │ ├─ [email protected]
│ │ │ ├─ [email protected]
│ │ │ └─ [email protected]
│ │ ├─ [email protected]
│ │ ├─ [email protected]
│ │ └─ [email protected]
│ └─ [email protected]
│ ├─ [email protected]
│ ├─ [email protected]
│ ├─ [email protected]
│ │ └─ [email protected]
│ └─ [email protected]
└─ [email protected]
this is back again thanks