modali icon indicating copy to clipboard operation
modali copied to clipboard

react-syntax-highlighter

Open bwilsoncc opened this issue 6 years ago • 2 comments

Looks to me like you could remove the react-syntax-highlighter dependency. Oh - I see references to it in the examples but shouldn't it not be in the npm release package?

bwilsoncc avatar Aug 22 '19 00:08 bwilsoncc

I agree with this, react-syntax-highlighter has some additional dependencies, and even if this is not included in the bundle it adds complexity and possibly unnecessary security warnings from NPM. Could we move react-syntax-highlighter to devDependencies?

This is the dependency tree for react-syntax-highlighter:

$ npx npm-remote-ls react-syntax-highlighter --development=false
└─ [email protected]
   ├─ @babel/[email protected]
   │  └─ [email protected]
   ├─ [email protected]
   │  └─ [email protected]
   │     ├─ [email protected]
   │     ├─ [email protected]
   │     │  └─ [email protected]
   │     └─ [email protected]
   ├─ [email protected]
   │  ├─ [email protected]
   │  │  └─ [email protected]
   │  └─ [email protected]
   ├─ [email protected]
   │  ├─ [email protected]
   │  ├─ [email protected]
   │  │  ├─ [email protected]
   │  │  ├─ [email protected]
   │  │  ├─ [email protected]
   │  │  │  ├─ [email protected]
   │  │  │  └─ [email protected]
   │  │  ├─ [email protected]
   │  │  ├─ [email protected]
   │  │  └─ [email protected]
   │  └─ [email protected]
   │     ├─ [email protected]
   │     ├─ [email protected]
   │     ├─ [email protected]
   │     │  └─ [email protected]
   │     └─ [email protected]
   └─ [email protected]

mikaello avatar Oct 14 '19 10:10 mikaello

this is back again thanks

aaronleesmu avatar Nov 24 '22 02:11 aaronleesmu