elasticsearch-operator icon indicating copy to clipboard operation
elasticsearch-operator copied to clipboard

Scaling new

Open naredula-jana opened this issue 6 years ago • 6 comments

This is rebased scaling feature from "scaling" branch to the latest master branch.

naredula-jana avatar Jan 14 '19 10:01 naredula-jana

This is same as PR scaling #264 , rebased on to the latest master code.

naredula-jana avatar Jan 14 '19 10:01 naredula-jana

This is same as PR scaling #264 , rebased on to the latest master code. The unit test was failing, but scaling patch as no changes related to this error, the error as below, Any idea about this?.

import cycle not allowed in test package github.com/upmc-enterprises/elasticsearch-operator/pkg/k8sutil (test) imports github.com/upmc-enterprises/elasticsearch-operator/pkg/k8sutil

naredula-jana avatar Jan 16 '19 06:01 naredula-jana

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

stevesloka avatar Jan 23 '19 02:01 stevesloka

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

This cycle import is not related to scaling patch. This PR is same as that of PR scaling - 264 , except that it is rebased to new master.

naredula-jana avatar Jan 23 '19 03:01 naredula-jana

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

This cycle import is not related to scaling patch. This PR is same as that of PR scaling - 264 , except that it is rebased to new master.

The build is sucessfull without unit test code, but the build errored if the unit test code is included, the same unit test code was sucessfull without rebase(PR-264), and also sucessfull locally. there was something change in the build or at other places with code rebase.

naredula-jana avatar Jan 24 '19 17:01 naredula-jana

Hey @naredula-jana sounds like you've got a cycle import, where one package imports another which imports the first.

This cycle import is not related to scaling patch. This PR is same as that of PR scaling - 264 , except that it is rebased to new master.

Solved the above issue, Now the unit test is Successful.

naredula-jana avatar Jan 26 '19 20:01 naredula-jana