blocks icon indicating copy to clipboard operation
blocks copied to clipboard
verified publisher icon uploadcare

localeDefinitionOverride not overriding on vue example

Open iqbaltawakkal opened this issue 1 year ago • 3 comments

Describe the bug localeDefinitionOverride not override label in all file upload (minimal, regular, inline)

To Reproduce Steps to reproduce the behavior: I'm using file-uploader official example for vue

  1. Go to 'codesandbox'
  2. Scroll down to button upload
  3. Button title is not overridden

Expected behavior Button title should be 'Upload photos' instead of 'Upload files'

Screenshots image

Desktop (please complete the following information):

  • OS: Windows
  • Browser chrome
  • Version 127.0.6533.119

iqbaltawakkal avatar Aug 16 '24 10:08 iqbaltawakkal

Hey @iqbaltawakkal,

Thanks for the feedback!

There was a mistake: the localeDefinitionOverride property should be assigned to the uc-config element instead of the uc-upload-ctx-provider. I have updated the Codesandbox, so it's fixed now.

nd0ut avatar Aug 16 '24 10:08 nd0ut

hi @nd0ut thanks, I also submit PR for the composition one https://github.com/uploadcare/blocks-examples/pull/35

iqbaltawakkal avatar Aug 16 '24 11:08 iqbaltawakkal

hi @nd0ut thanks, I also submit PR for the composition one uploadcare/blocks-examples#35

Merged. Thanks!

nd0ut avatar Aug 16 '24 12:08 nd0ut