[Bug]: Plugin is not saving the settings properly - returns to default settings partially

[mrbeatbox]

Describe the bug

After setting the simple settings like "enable the Task plugin setting", "Remove tags", and "Distinguish between reminder and due date"

i set all of them to enable. closed the settings page and pressed the hotkey for the calender pop out. but the reminders still do have the tags and the start of the week was not what i selected.

Expected Behavior

The settings for the reminder should be saved as i close it and the things i have enabled should be used by the plugin

Steps to reproduce

I did a clean install of the plugin and it still happens

Operating system

Windows

[foresthoffman]

This was happening for me as well after updating to the latest version, 1.1.21.

I double checked that my useCustomEmojiForTasksPlugin was set to true, and it is. However, the Reminder plugin will no longer insert the ⏰ format into the Obsidian Task value.

I tried creating a task without a reminder, just a due date, and the reminder would occur 5 seconds after creating the task. This indicates that the Reminder plugin is pulling the due date (📆) from the task and assuming the default reminder timestamp of 9:00AM.

I tried creating a task without a due date, and then used the Reminder calendar popup to assign a timestamp within 15 minutes. The calendar popup inserted a due date into the task. This time, the reminder popped up 3 seconds after creating the task.

I did the above tests with only the Obsidian Task and Reminder plugins enabled.

This is an issue on Windows 11 and on iOS 18.6

[foresthoffman]

Through further testing I can confirm that the ReminderFormatParameterKey.useCustomEmojiForTasksPlugin is true when loading the plugin, but it is false (causing useCustomEmoji() to be incorrectly false) when using the showDateTimeChooserModal is used instead of the intended DateTimeChooserView. This situation always occurs because CodeMIrror version 6 doesn't support charCoords or defaultTextHeight anymore. CM6 deprecated those functions, however their types package is outdated, so it still includes the deprecated functions.

There might be some alternative functions, but I don't know that there's a direct replacement.

I messed around with the DateTimeChooserView code a bit and mitigated the bug with CM6, but the reminder still wasn't being inserted in the correct format. It was ignoring the setting to use the custom emoji for task reminders.

[uphy]

Thank you for the report and investigation. I have confirmed the phenomenon and the cause location. I will fix it soon.

[notaLonelyDay]

same