gym-electric-motor icon indicating copy to clipboard operation
gym-electric-motor copied to clipboard

Renaming of PhysicalSystem Class

Open atra94 opened this issue 4 years ago • 1 comments

In my opinion, the name PhysicalSystem could be improved for more clarity on its purpose.

The PhysicalSystem is the part to combine all models of the subsystems (Motors, Loads, Converters etc.) into one and to execute the simulation.

Therefore I would suggest to name it "SystemModel" or "CompoundSystem".

I would also appreachiate more and better suggestions. 😃

atra94 avatar May 11 '20 20:05 atra94

Good initiative, but requirse bird's eye view on the entire could package. Renaming on global basis in the future.

wallscheid avatar Jun 19 '20 11:06 wallscheid