gym-electric-motor icon indicating copy to clipboard operation
gym-electric-motor copied to clipboard

Refactoring, StateObserver and Python Tooling

Open devarndt opened this issue 11 months ago • 2 comments

Important files:

  • observer.py
  • DEVELOPMENT.md
  • many small changes

[2.0.1] - Unreleased

Added

  • Ruff: Python linter & formatter (see DEVELOPMENT.md)
  • StateObserver: An easy way to get state values with error checking example
  • Integrated gem_controls repository into gem. classic_controllers will be removed in further version
  • Using pyproject.toml, dropping deprecated setup.py
  • Enabled Gymnasium env checker see here

Changed

  • Linted and formatted all files
  • Changed max. steps in some test files to improve test speed by 30%

Fixed

devarndt avatar Mar 07 '24 19:03 devarndt

I was not successful to run the unit tests locally: ModuleNotFoundError: No module named 'classic_controllers'

Did I miss an optional install or is something missing from the requirements? Also, GitHub still reports the tests to not be successful for Python 3.8. Is that fixable?

max-schenke avatar Apr 02 '24 12:04 max-schenke

I was not successful to run the unit tests locally:

ModuleNotFoundError: No module named 'classic_controllers'

Did I miss an optional install or is something missing from the requirements?

Also, GitHub still reports the tests to not be successful for Python 3.8. Is that fixable?

I will look into it on Thursday.

devarndt avatar Apr 02 '24 13:04 devarndt

Integration test still fails on my machine, all other tests seems successful.

Also, GitHub still reports Version 3.8 to have failing tests.

Formatting issues persist and make it hard to read coded matrices.

max-schenke avatar May 13 '24 09:05 max-schenke