up-for-grabs.net icon indicating copy to clipboard operation
up-for-grabs.net copied to clipboard

Pagination

Open ritwik12 opened this issue 8 years ago • 22 comments

This issue is related to #303 I am opening this issue again as I think nobody is considering the old #303 From my point of view, pagination is really required. Whenever someone is searching for a good project to work on we always compare it with other projects. Pagination helps us to see a certain list of projects at once. It makes easy to search for the desired project.

ritwik12 avatar Jul 12 '17 16:07 ritwik12

As per the initial issue, @apoorvnandan had a concept of this - realistically, either waiting for a PR from them and/or replicating their concept would do just fine.

aph3rson avatar Jul 15 '17 03:07 aph3rson

Is this still open?

cmdrwebdev avatar Aug 10 '17 10:08 cmdrwebdev

@cmdrwebdev Yes it is open and you may work and submit a PR.

ritwik12 avatar Aug 10 '17 13:08 ritwik12

@cmdrwebdev Have you tried?

ritwik12 avatar Aug 28 '17 16:08 ritwik12

@cmdrwebdev Is this still open ? I want to contribute.

layely avatar Sep 11 '17 17:09 layely

@cmdrwebdev Yes it is, As long as we don't get a PR.

ritwik12 avatar Sep 11 '17 17:09 ritwik12

@ritwik12 OK. So I am working on it

layely avatar Sep 11 '17 17:09 layely

@ritwik12

Here what i have:

  • 20 projects per page
  • All projects are loaded at once of course
  • when we move to the next page or previous page, auto-scroll (with animation) to the first project in that page
  • URI now looks like up-for-graps.net/#/page//tags/ (eg. www.up-for-graps.net/#/page/3/ or www.up-for-graps.net/#/page/3/tags/.net

up-for-graps-pagination

giphy

via GIPHY

layely avatar Sep 13 '17 06:09 layely

@layely Good work, Now please send a PR referring this issue.

ritwik12 avatar Sep 13 '17 08:09 ritwik12

@ritwik12 PR sent

layely avatar Sep 14 '17 01:09 layely

#727 is pending from about a month, please review @shiftkey and @dahlbyk

ritwik12 avatar Oct 07 '17 07:10 ritwik12

I took a look at the errors @layely had in his PR that caused @ritwik12 to revert and made some changes here https://github.com/djm158/up-for-grabs.net/tree/pagination/gh-pages. Worth making a PR? Is this issue still on the table?

djm158 avatar Feb 21 '18 05:02 djm158

@djm158 yes it's still open. You may work on it 🙂

ritwik12 avatar Feb 21 '18 05:02 ritwik12

@shiftkey @ritwik12 can I take this up ?

Priyanka488 avatar Sep 26 '19 17:09 Priyanka488

@Priyanka488 sure. There's an old PR #887 worth looking at which I haven't had a chance to review, but I'll try and provide feedback if you open a new PR or try something different.

shiftkey avatar Sep 26 '19 17:09 shiftkey

Is this issue still open because I really liked what @layely did , but I still don't see the implementation in the website.

Jai2305 avatar Sep 12 '21 04:09 Jai2305

@Jai2305 This is still open, the PR had few bugs due to which I had to revert it.

ritwik12 avatar Sep 12 '21 11:09 ritwik12

Hi, is this issue still? Would like to have a crack at it

renzos75 avatar Mar 25 '22 00:03 renzos75

Hey @ritwik12 I'd like to work on this issue, please assign this to me. I think that adding a pagination is really important to level up user experience so I'll try my best to contribute this feature.

utkarshgoel10 avatar Oct 06 '22 12:10 utkarshgoel10

Hi @ritwik12 I want to work on this issue. Please assign this to me.

himanshu-pareek avatar Aug 25 '23 12:08 himanshu-pareek