Favicon Not Visible in Browser Dark Mode

[solomonsanderson]

I have seen issues #3026 and #3545 which mention a new logo, none of these mention the favicon. This appears simply as a circle when using dark mode in chrome.

[dinesh671]

hey there we need to create two different icons for dark and light mode and we need to use some attributes to use the icons dynamically so that we can appropriate icons for there themes. i would like work on it could please assign this issue for me

[enricozz]

I made some icons:

Home Screen -

Favicon -

[c9ssio]

I just added this new favicon, but why so many favicons with different sizes?

[dinesh671]

after creating different icons, call this icons in the html page with to different link tags, and then add the media="(prefers-color-scheme: dark)" and media="(prefers-color-scheme: light)"

[dinesh671]

hey actually the problem is we need to create a new logo for dark mode. the logo should be have #58585A color filled arm and #FFFFFF color of stroke. creating this type of logo the gray fill will be invisible in dark mode and the white stroke in dark mode will be visible as we can see currently a small circle is visible by adding this icon with that attributes mentioned in before comment we can solve this issue

[dinesh671]

hey you know what i got new simple solution just add the white background to the favicon then it will look good

[solomonsanderson]

@dinesh671 Which .html file do you think this should be added to?

add the media="(prefers-color-scheme: dark)" and media="(prefers-color-scheme: light)"

[dinesh671]

i think in head.html @solomonsanderson

[mickey097]

On Thu, Nov 24, 2022 at 9:43 AM DVS Dinesh Kumar @.***> wrote:

i think in head.html

— Reply to this email directly, view it on GitHub https://github.com/up-for-grabs/up-for-grabs.net/issues/3611#issuecomment-1326609555, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BOBAOYTG42UGZ6EEV34XDWJ6EJBANCNFSM6AAAAAASCHJ57Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Yes

[neuralpain]

Is this issue open or closed? If closed then #3026 and #3545 should be closed as well, no?

[ritwik12]

@solomonsanderson Is this still valid after #3546?

[dinesh671]

@ritwik12 as you have added the logo that doesn't solved the issue fav-icon is not visible

[munnokd]

Hey @dinesh671 can I work on this issue?

[dinesh671]

hey @munnokd I am not the admin of the group please ask @mickey097 I am also waiting for his reply

[munnokd]

@mickey097 Can you assign this issue to me?

[MehmetTerc]

Can you assign this issue to me?

[Diegogonzalez1008]

Wtf are we doing explain please

[Diegogonzalez1008]

I need money

[Sam10-debug]

Hello, can this issue be assigned to me

[Shashankpantiitbhilai]

please assign this to me