up-for-grabs.net icon indicating copy to clipboard operation
up-for-grabs.net copied to clipboard

Accessibility: For some odd reason screenreaders don't see the list of projects

Open zersiax opened this issue 4 years ago • 9 comments

Just had a super quick look at this page and something odd appears to be happening. The entire projects section between the " Projects" h1 and the "I want to get involved" h1 is just completely invisible for screenreader users. I see the elements in the DOM tree, but something is making the screenreader think that part is not actually part of the DOM. The usual suspect is an errand aria-hidden somewhere, which I didn't immediately see in the code, or a display: none that can only be removed by clicking an icon that isn't visible to screenreader users. I didn't immediately see that either, not on the entire div that is. Any clue what might be happening here? Is the project list collapsed by default, visually speaking? (can't check, blind developer myself :) )

zersiax avatar Jun 16 '21 01:06 zersiax

Hi!

I am using the NVDA screenreader and everything seems to still be working fine. Is this still an issue for you?

genderplugin avatar Jun 28 '21 17:06 genderplugin

Hmm. No, or well ...not in Firefox, but yes in Chrome and Edge, where I have adblockers running. I see an error in the console abou google analytics erroring out, might that be why?

zersiax avatar Jun 28 '21 18:06 zersiax

@zersiax Did you tried without Adblockers? This should not be an issue as we are not serving ads. Maybe your ad blocker is blocking even google analytics.

ritwik12 avatar Jun 28 '21 19:06 ritwik12

visually speaking? (can't check, blind developer myself :) )

@zersiax I am really impressed to see that you are contributing to Open Source. if you are a beginner or need any help. Feel free to pop a mail to me anytime. Would be happy to help :)

ritwik12 avatar Jun 28 '21 19:06 ritwik12

Looks like tracker_prevention settings in the browser are blocking Google Analytics ...which makes sense, given GA is a tracker :) Might be that GA is in the minified JS before the list of filters gets loaded, that would probably cause this behavior :)

zersiax avatar Jun 28 '21 19:06 zersiax

@zersiax Thanks for taking a look. From what I can see in _includes/scripts.html at https://github.com/up-for-grabs/up-for-grabs.net/blob/gh-pages/_includes/scripts.html. The GA is mentioned at the last only.

ritwik12 avatar Jun 28 '21 19:06 ritwik12

@ritwik12 sorry to hop on but could I send you an email as well? having trouble finding a good first issue to tackle and would love some tips.

genderplugin avatar Jun 29 '21 00:06 genderplugin

@ethanstarcher Sure, I was thinking of taking your name also. Please let me know if I can help you.

ritwik12 avatar Jun 29 '21 12:06 ritwik12

Uploading macOSServer57_compressed.pdf…

mervy93 avatar Oct 15 '22 09:10 mervy93