zubhub icon indicating copy to clipboard operation
zubhub copied to clipboard

(feat) Notification bell doesn't show notifications

Open coderatomy opened this issue 2 years ago • 5 comments

Summary

Implements notifiers in case of numbers. Closes #992

Changes

  • Adds notifications number

Screenshots

image Screenshot from 2023-11-09 02-02-02

coderatomy avatar Nov 08 '23 23:11 coderatomy

@coderatomy Thanks for this. The current design does not match exactly the suggested UX in #992 (notification circle should be half outside the main bell circle). I also think we should experiment with increasing the font size of the notification count. In addition, have you tested the behavior when all notifications are read already? Does the icon work as expected (it should not show 0, but should just disappear).

tuxology avatar Nov 10 '23 18:11 tuxology

Everything works as expected. For the design @mehreeee updated it to this

coderatomy avatar Nov 10 '23 19:11 coderatomy

Everything works as expected. For the design @mehreeee updated it to this

hi @tuxology I iterated and updated the design to this current one. Maybe we could try increasing the font for greater legibility.

mehreeee avatar Nov 10 '23 19:11 mehreeee

Something we should probably do in the future is to implement push notification. Right now users don't get notified unless they perform some kind of action that results in the frontend hitting the notification endpoint

NdibeRaymond avatar Nov 12 '23 02:11 NdibeRaymond

@coderatomy Ok, I see that there was an update to the design 🤔 Its fine, we go with this design then. Note that the icon+notification bubble together is centered and has consistent padding along the sides so it looks balanced. In your implementation we see the notification bubble touching the outer circle edge. In addition, lets do changes requested by @NdibeRaymond as well Thanks @NdibeRaymond for testing. We'll merge this soon.

tuxology avatar Nov 21 '23 21:11 tuxology