(feat) Notification bell doesn't show notifications
Summary
Implements notifiers in case of numbers. Closes #992
Changes
- Adds notifications number
Screenshots
@coderatomy Thanks for this. The current design does not match exactly the suggested UX in #992 (notification circle should be half outside the main bell circle). I also think we should experiment with increasing the font size of the notification count. In addition, have you tested the behavior when all notifications are read already? Does the icon work as expected (it should not show 0, but should just disappear).
Everything works as expected. For the design @mehreeee updated it to this
Everything works as expected. For the design @mehreeee updated it to this
hi @tuxology I iterated and updated the design to this current one. Maybe we could try increasing the font for greater legibility.
Something we should probably do in the future is to implement push notification. Right now users don't get notified unless they perform some kind of action that results in the frontend hitting the notification endpoint
@coderatomy Ok, I see that there was an update to the design 🤔 Its fine, we go with this design then. Note that the icon+notification bubble together is centered and has consistent padding along the sides so it looks balanced. In your implementation we see the notification bubble touching the outer circle edge. In addition, lets do changes requested by @NdibeRaymond as well Thanks @NdibeRaymond for testing. We'll merge this soon.