zubhub icon indicating copy to clipboard operation
zubhub copied to clipboard

Move change password feature to a new tab

Open srish opened this issue 1 year ago • 24 comments

@NdibeRaymond raised an important point here https://github.com/unstructuredstudio/zubhub/pull/968#issuecomment-1784234605 about why the change password feature should not be available on the edit profile page but on a different tab related to account settings.

So, this issue is about designing the new account settings tab. The "Account settings" menu option can be added on the user sidebar above the logout option. Upon clicking the account settings menu, it should open the change password form.

Ideally, we have a UX design for this feature first before the implementation step.

srish avatar Oct 30 '23 21:10 srish

Hi @srish like I suggested in https://github.com/unstructuredstudio/zubhub/issues/904, we can add a settings button to the side navigation panel for this feature. Here are my suggestions, let me know what you think

Sign Up option3

Sign Up option5

Sign Up option4

mehreeee avatar Oct 30 '23 22:10 mehreeee

@mehreeee nice designs. However, the button in your first iteration looks greyed out and unclickable. Still can't view the second one yet.

DonPresh avatar Oct 30 '23 23:10 DonPresh

@mehreeee nice designs. However, the button in your first iteration looks greyed out and unclickable. Still can't view the second one yet.

Thank you Presh. Sorry that was a mistake. I've rectified it now

mehreeee avatar Oct 30 '23 23:10 mehreeee

@mehreeee nice designs. However, the button in your first iteration looks greyed out and unclickable. Still can't view the second one yet.

Thank you Presh. Sorry that was a mistake. I've rectified it now

This looks better. Good job!

DonPresh avatar Oct 31 '23 02:10 DonPresh

@Mehree and @srish These are the different ways i feel we could solve this problem

First suggestion: Test 1

Second suggestion: Test 2

Third suggestion Test 4

The Visual designs are still going to be worked on. Pls review. Thank you.

DonPresh avatar Oct 31 '23 02:10 DonPresh

Nice work @mehreeee @DonPresh

To add to what you guys have designed, on the change password page , I feel a forgot password link should be beneath the current password input field for users that can't remember their current password and wants to change it. When they click on it, they are redirected to a "Password Reset" page where they are prompted to enter their email address. After entering their email, they should receive a confirmation message indicating that a password reset link has been sent to their email.

For the change password, I came up with suggestions that shows you the password strength as you type your new password, a real-time password strength indicator. This indicator displays the password's strength as users type their new password, providing immediate feedback on password security it also enhances user awareness and encourages the creation of stronger and more secure passwords.

See screenshot below @srish

image

Used red to represent weak image

Used green to represent strong image

Dumzy006 avatar Oct 31 '23 08:10 Dumzy006

@mehree and @srish These are the different ways i feel we could solve this problem

First suggestion: Test 1

Second suggestion: Test 2

Third suggestion Test 4

The Visual designs are still going to be worked on. Pls review. Thank you.

Nice design @DonPresh

mehreeee avatar Oct 31 '23 08:10 mehreeee

Nice work @mehreeee @DonPresh

To add to what you guys have designed, on the change password page , I feel a forgot password link should be beneath the current password input field for users that can't remember their current password and wants to change it. When they click on it, they are redirected to a "Password Reset" page where they are prompted to enter their email address. After entering their email, they should receive a confirmation message indicating that a password reset link has been sent to their email.

For the change password, I came up with suggestions that shows you the password strength as you type your new password, a real-time password strength indicator. This indicator displays the password strength as users type their new password.

See screenshot below @srish

image

Used red to represent weak image

Used green to represent strong image

Nice work @Dumzy006 funny I just thought about the same this morning. I've been iterating since last night. Well done.

mehreeee avatar Oct 31 '23 08:10 mehreeee

Nice work guys @Dumzy006 @mehreeee . I like the use of green to indicate strength and weakness

DonPresh avatar Oct 31 '23 09:10 DonPresh

I love the design @Dumzy006 but can we have "Password too short" as indicators instead of weak, as it is more understandable for young users

aqsaaqeel avatar Oct 31 '23 11:10 aqsaaqeel

I love the design @Dumzy006 but can we have "Password too short" as indicators instead of weak, as it is more understandable for young users

@aqsaaqeel what about a situation where the password is actually weak? I agree with re-wording for our young users but if it's weak, they should also know it's weak and have indicators for when their password is strong as @Dumzy006 has already shown.

DonPresh avatar Oct 31 '23 11:10 DonPresh

Nice work guys @mehreeee @DonPresh @Dumzy006

Marhiposa avatar Oct 31 '23 13:10 Marhiposa

Nice work guys @mehreeee @DonPresh @Dumzy006

Thank you 🙏

mehreeee avatar Oct 31 '23 17:10 mehreeee

great job @Dumzy006 @DonPresh @mehreeee 👏🏻 Are we going to show a link to the 'change password' page in the edit profile as suggested here? #968 (comment)

brrkrmn avatar Nov 01 '23 06:11 brrkrmn

great job @Dumzy006 @DonPresh @mehreeee 👏🏻 Are we going to show a link to the 'change password' page in the edit profile as suggested here? #968 (comment)

Thank you @brrkrmn I don't think there's a need to put a link to change password in the edit profile page, rather it should be on the change password page. That's why I removed the 'current password' form field from the edit profile page on the last frame of my design here https://github.com/unstructuredstudio/zubhub/issues/984#issuecomment-1786137748.

mehreeee avatar Nov 01 '23 06:11 mehreeee

oh got it @mehreeee thanks. Guess I missed this last frame, looks great

brrkrmn avatar Nov 01 '23 06:11 brrkrmn

Hi, @srish Amazing ideas and design as always guys 🚀, I am glad @mehreeee mentioned password requirements and meter.

I want to note that, there should be some consistency throughout the site, that is if we iterate on the design/UX of the change password we should not forget at the level of Registration. Also, Zubhub already has some sort of a "strength meter". It starts with the password being too short and then later when I am about to create an account I am told I can't create an account because the password is too weak. It is an issue I was thinking about opening but I thought it would be considered a minor issue and never submitted it. Can I create an issue for that?

Talking about the account settings:

  1. When the user clicks on the edit profile, it can be redirected to the account settings tab. There the user can see everything about the account like profile, password and option to delete the account.
Account
  1. Or just move juts the password and that ability to delete the account
Password-acct

Talking about password validation rules:

pass_validation

roznaj avatar Nov 01 '23 07:11 roznaj

I love the design @Dumzy006 but can we have "Password too short" as indicators instead of weak, as it is more understandable for young users

@aqsaaqeel what about a situation where the password is actually weak? I agree with re-wording for our young users but if it's weak, they should also know it's weak and have indicators for when their password is strong as @Dumzy006 has already shown.

Currently, we only want to show validation for when a password length > 8 to avoid complexity. So having one warning message should work.

cc: @srish @tuxology

aqsaaqeel avatar Nov 01 '23 18:11 aqsaaqeel

Nice work @roznaj. We shall consider a few of those to display, just to keep the design simpler

coderatomy avatar Nov 03 '23 11:11 coderatomy

Thanks everyone for your collaboration on this task!

Let's go with @roznaj's first design here https://github.com/unstructuredstudio/zubhub/issues/984#issuecomment-1788546158.

The edit button would need to be removed from profile page accordingly. And, let's have "Settings" menu option right above logout option in the sidebar.

Dev taking up ensure that design elements remain consistent with current components such as radius, color scheme, size, etc.

srish avatar Nov 10 '23 18:11 srish

Working on this.

aqsaaqeel avatar Nov 11 '23 00:11 aqsaaqeel

hey @aqsaaqeel, please look up at the linked PR.

coderatomy avatar Nov 11 '23 03:11 coderatomy

hey @aqsaaqeel, please look up at the linked PR.

There is none

aqsaaqeel avatar Nov 13 '23 19:11 aqsaaqeel

@roznaj can you share the figma file of your design

aqsaaqeel avatar Nov 13 '23 20:11 aqsaaqeel