zubhub icon indicating copy to clipboard operation
zubhub copied to clipboard

Feat/new auth flow fix

Open yokwejuste opened this issue 1 year ago • 6 comments

Summary

This PR is an implementation of the new auth flow.

Copy of #1081

yokwejuste avatar Mar 02 '24 05:03 yokwejuste

pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.

github-actions[bot] avatar Mar 02 '24 05:03 github-actions[bot]

pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.

github-actions[bot] avatar Mar 02 '24 05:03 github-actions[bot]

pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.

github-actions[bot] avatar Mar 05 '24 00:03 github-actions[bot]

pre-commit checks failed ❌❌❌ make sure you have pre-commit set up locally (see the README.md for instructions). If you have set up pre-commit locally, you may need to undo this commit and run "pre-commit" locally to see what the errors are.

github-actions[bot] avatar Mar 05 '24 05:03 github-actions[bot]

You should also rebase, and fix the failing pre-commit changes. I posted the link to a video I made on zulip, about how to go about that

NdibeRaymond avatar Mar 05 '24 15:03 NdibeRaymond

part of that failing pre-commit test is the little test we have on the backend for user creation. You need to update the test to make sure it passes. Right now it's failing, which is a pointer that the PR is failing. This looks to be the same PR that was reverted right?

NdibeRaymond avatar Mar 05 '24 15:03 NdibeRaymond