url-transformers icon indicating copy to clipboard operation
url-transformers copied to clipboard

`url` should be a peer dependency

Open samhh opened this issue 2 years ago • 2 comments

Or we can stop using it as per #15.

samhh avatar Apr 20 '22 19:04 samhh

Even for Node? For Node it's built-in.

OliverJAsh avatar Apr 21 '22 10:04 OliverJAsh

To answer my own question: it's needed when someone tries to use this library outside of Node i.e. in the browser.

In that case, I'm not sure whether we should list url as a dependency or expect consumers to provide it themselves.

OliverJAsh avatar Apr 21 '22 10:04 OliverJAsh