unsend icon indicating copy to clipboard operation
unsend copied to clipboard
verified publisher icon unsend-dev

Feature/email rate limiting

Open SuperALKALINEdroiD opened this issue 11 months ago • 7 comments

SuperALKALINEdroiD avatar Jan 18 '25 06:01 SuperALKALINEdroiD

@KMKoushik did something on rate limitting, can you please review and give some notes/feedbacks

SuperALKALINEdroiD avatar Jan 18 '25 06:01 SuperALKALINEdroiD

I will need more information on this, Things are already rate limitted on team as I can see on the token function in the send email method

SuperALKALINEdroiD avatar Jan 26 '25 10:01 SuperALKALINEdroiD

I’ve updated the endpoint and included teamId in the rate limiter token. Could you please review it again and share your feedback or any suggestions for improvement?

SuperALKALINEdroiD avatar Jan 26 '25 20:01 SuperALKALINEdroiD

Hey @KMKoushik when can I expect a review

SuperALKALINEdroiD avatar Feb 18 '25 19:02 SuperALKALINEdroiD

Hello @KMKoushik I am still looking for some feedback on this PR

SuperALKALINEdroiD avatar Mar 09 '25 07:03 SuperALKALINEdroiD

@SuperALKALINEdroiD sorry missed this, i think the rate limit for each team should be strored in database for each team rather than env. this is more of a cloud feature. on-prem doesn't really need rate-limiting tbh

KMKoushik avatar Mar 10 '25 08:03 KMKoushik

@KMKoushik moved rate limit settings to team, could you please check if this looks OK. I will add UI changes aswell if this is good enough

SuperALKALINEdroiD avatar Mar 22 '25 12:03 SuperALKALINEdroiD

sorry had to this myself, based on the cloud need

KMKoushik avatar Aug 30 '25 05:08 KMKoushik