workshops icon indicating copy to clipboard operation
workshops copied to clipboard

Dev/mama/docs-Figma-UI-Import-update

Open mtmattei opened this issue 1 year ago • 5 comments

Description (*)

Fixed Issues (if necessary)

Screenshots (if necessary)

Contribution checklist (*)

  • [x] I have read the Contributing Guidelines
  • [x] Commits have been made with meaningful commit messages
  • [x] All automated tests have passed successfully

mtmattei avatar Nov 09 '23 20:11 mtmattei

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: nickrandolph
:white_check_mark: mtmattei
:x: Matt


Matt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 09 '23 20:11 CLAassistant

@mtmattei some of the comments I've left are based on personal style. Feel free to simply close them if you disagree.

weitzhandler avatar Nov 10 '23 03:11 weitzhandler

Not related to Matthew changes, but the following links are broken when running docfx:

  • https://github.com/unoplatform/workshops/blob/d8619754bae9edda5f24377c0878ccde858cd7ce/simple-calc/modules/Resources/XAML/Customizing-Palette.md?plain=1#L9

  • https://github.com/unoplatform/workshops/blob/d8619754bae9edda5f24377c0878ccde858cd7ce/simple-calc/modules/Resources/CSharp/Customizing-Palette.md?plain=1#L9

They should be changed to follow this type of snippet:

https://github.com/unoplatform/workshops/blob/d8619754bae9edda5f24377c0878ccde858cd7ce/simple-calc/modules/MVUX-CSharp/01-Build%20your%20first%20Project/README.md?plain=1#L30-L34

cc @nickrandolph @agneszitte @weitzhandler @mtmattei

eriklimakc avatar Nov 10 '23 10:11 eriklimakc

@mtmattei I am a bit confused about the screenshots updates here They are not following the figma file or the default material styles colors We will sync on this tomorrow please image image

Yes your right, we can ignore those screenshots but initially when I opened the SimpleCalc from the community file, that is what the Calculator looked like. I reopened it and it is different now..

mtmattei avatar Nov 10 '23 13:11 mtmattei

Not related to Matthew changes, but the following links are broken when running docfx:

  • https://github.com/unoplatform/workshops/blob/d8619754bae9edda5f24377c0878ccde858cd7ce/simple-calc/modules/Resources/XAML/Customizing-Palette.md?plain=1#L9

Check what the location of the files is after being rendered (browse the exported files by removing the _site and the page), then make sure it points to the proper location.

weitzhandler avatar Nov 10 '23 15:11 weitzhandler