uno icon indicating copy to clipboard operation
uno copied to clipboard

feat(Wasm,Skia,iOS): Support FontStretch for TextBlock and TextElement

Open Youssef1313 opened this issue 3 years ago • 5 comments

GitHub Issue (If applicable): Part of #7614

PR Type

What kind of change does this PR introduce?

What is the current behavior?

FontStretch not supported.

What is the new behavior?

Skia GTK:

image

Skia WPF:

image

Wasm:

image

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Youssef1313 avatar Sep 16 '22 11:09 Youssef1313

gitpod-io[bot] avatar Sep 16 '22 11:09 gitpod-io[bot]

Test is failing on Skia WPF in CI, but is passing locally 😕

For iOS, test is failing, and I can't see what's going on as I don't have a device.

For Wasm, test is disabled because RenderTargetBitmap doesn't seem to be implemented, but from the manual test, things are working well

https://github.com/unoplatform/uno/blob/fe91406526782b70f86273149f1c291903afa5f9/src/Uno.UI/UI/Xaml/Media/Imaging/RenderTargetBitmap.cs#L2-L4

Youssef1313 avatar Sep 19 '22 10:09 Youssef1313

@jeromelaban I'm not sure how can I move forward with this PR :(

Youssef1313 avatar Sep 19 '22 14:09 Youssef1313

There's at least the Skia tests that you can validate: https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=1983794&_a=resultSummary&resultId=104292

jeromelaban avatar Sep 20 '22 13:09 jeromelaban

As for iOS failing, you can take a look at the screenshots here: https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=1983788&_a=resultSummary&resultId=100000 (the Tear_down_on_error.png one). The interesting part is that the text should show on the right side of the screen but does not. (and there's a weird text superposition on the left side of the screen).

jeromelaban avatar Sep 20 '22 13:09 jeromelaban

@Youssef1313 Is this still relevant or should be closed as it was superseeded with other changes later?

MartinZikmund avatar Jul 01 '24 14:07 MartinZikmund