uno icon indicating copy to clipboard operation
uno copied to clipboard

feat: Adding support for CustomTabs and fix ASWebAuthenticationSession in WebAuthenticationBroker

Open nickrandolph opened this issue 3 years ago • 1 comments

GitHub Issue (If applicable): closes #9338

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

What is the current behavior?

Android: Doesn't use customtabs which is now the recommended model for doing web based authentication in an app iOS: ASWebAuthenticationSession throws exception in contructor when a full url is used as callbackuri (ie scheme://path instead of just scheme )

What is the new behavior?

Android: Now uses fall back from CustomTabs (if available) to external browser iOS: ASWebAuthenticationSession uses callbackuri.scheme instead of the whole callbackuri

PR Checklist

Please check if your PR fulfills the following requirements:

nickrandolph avatar Jul 22 '22 09:07 nickrandolph

gitpod-io[bot] avatar Jul 22 '22 09:07 gitpod-io[bot]

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

welcome[bot] avatar Aug 11 '22 13:08 welcome[bot]