uno
uno copied to clipboard
test: Adds Button_Events_Hover, Button_Events_Press, and Button_Event…
…s_Release tests to SamplesApp to test button conformance against UWP's behavior for the three ClickMode enumerators. These are useful for testing #7888
GitHub Issue (If applicable): #7888
PR Type
What kind of change does this PR introduce?
- Other... Please describe: SamplesApp tests
What is the current behavior?
The Button_Events test doesn't test ClickMode.Hover and ClickMode.Press and its UI isn't designed for testing on Android and other small form-factor devices.
What is the new behavior?
Button_Events still exists but now there are also Button_Events_Hover, Button_Events_Press, and Button_Events_Release that are configured to test each of the ClickMode enumerators with a UI designed to be usable on small form-factor devices. All are marked to not generate snapshots on WASM since WASM screenshots are (I believe) the only platfom that snapshots are currently tested on and snapshots would not reveal anything since the behavior requires mouse/touch input to test.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [x] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Run
results. - [x] Contains NO breaking changes
- [x] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [] Commits must be following the Conventional Commits specification.
Other information
It's associated with an issue but only provides tests for more easily testing the bugs reported in the issue; it doesn't provide any code changes other than adding the samples.
(This is the replacement for #7889 )
Internal Issue (If applicable):
Sorry about the second commit. I discovered that one of the UWP behaviors I documented for touch input was backwards as far as how long the touch should be held and discovered two other touch input related quirks while verifying Skia touch input behaviors. I fixed those, added some clarification notes about touch input behavior for the pointer entered and exited events, and made a few UI/UX improvements that make the tests easier to use.
Nice PR! It'll definitely be interesting to automate this with @dr1rrb's work on simulated input.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
@jeromelaban I re-run the CI yesterday but I think there are some tests that are failing for this PR if I'm not mistaken (cc @mikebmcl)