uno icon indicating copy to clipboard operation
uno copied to clipboard

test: Adds Button_Events_Hover, Button_Events_Press, and Button_Event…

Open mikebmcl opened this issue 3 years ago • 10 comments

…s_Release tests to SamplesApp to test button conformance against UWP's behavior for the three ClickMode enumerators. These are useful for testing #7888

GitHub Issue (If applicable): #7888

PR Type

What kind of change does this PR introduce?

  • Other... Please describe: SamplesApp tests

What is the current behavior?

The Button_Events test doesn't test ClickMode.Hover and ClickMode.Press and its UI isn't designed for testing on Android and other small form-factor devices.

What is the new behavior?

Button_Events still exists but now there are also Button_Events_Hover, Button_Events_Press, and Button_Events_Release that are configured to test each of the ClickMode enumerators with a UI designed to be usable on small form-factor devices. All are marked to not generate snapshots on WASM since WASM screenshots are (I believe) the only platfom that snapshots are currently tested on and snapshots would not reveal anything since the behavior requires mouse/touch input to test.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

It's associated with an issue but only provides tests for more easily testing the bugs reported in the issue; it doesn't provide any code changes other than adding the samples.

(This is the replacement for #7889 )

Internal Issue (If applicable):

mikebmcl avatar Jan 22 '22 21:01 mikebmcl

gitpod-io[bot] avatar Jan 22 '22 21:01 gitpod-io[bot]

Sorry about the second commit. I discovered that one of the UWP behaviors I documented for touch input was backwards as far as how long the touch should be held and discovered two other touch input related quirks while verifying Skia touch input behaviors. I fixed those, added some clarification notes about touch input behavior for the pointer entered and exited events, and made a few UI/UX improvements that make the tests easier to use.

mikebmcl avatar Jan 24 '22 00:01 mikebmcl

Nice PR! It'll definitely be interesting to automate this with @dr1rrb's work on simulated input.

jeromelaban avatar Jan 24 '22 13:01 jeromelaban

/azp run

dr1rrb avatar Mar 08 '22 14:03 dr1rrb

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 08 '22 14:03 azure-pipelines[bot]

/azp run

jeromelaban avatar Mar 23 '22 12:03 jeromelaban

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 23 '22 12:03 azure-pipelines[bot]

/azp run

agneszitte avatar Sep 13 '22 20:09 agneszitte

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Sep 13 '22 20:09 azure-pipelines[bot]

@jeromelaban I re-run the CI yesterday but I think there are some tests that are failing for this PR if I'm not mistaken (cc @mikebmcl)

agneszitte avatar Sep 14 '22 14:09 agneszitte