uno icon indicating copy to clipboard operation
uno copied to clipboard

feat: Add `ContentDialog` elevation on WASM & Android, partially on iOS

Open MartinZikmund opened this issue 2 years ago • 8 comments

GitHub Issue (If applicable): part of #7021

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

No shadow.

What is the new behavior?

Shadow working on WASM and Android. On iOS only without corner radius (not sure why - maybe @carldebilly would know?).

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

MartinZikmund avatar Sep 11 '21 12:09 MartinZikmund

gitpod-io[bot] avatar Sep 11 '21 12:09 gitpod-io[bot]

/azp run

jeromelaban avatar Oct 06 '21 13:10 jeromelaban

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 06 '21 13:10 azure-pipelines[bot]

Are we able to validate the presence of the elevation via a screenshot color peeking ?

jeromelaban avatar Oct 18 '21 13:10 jeromelaban

Looks like SetElevation is missing somewhere.

jeromelaban avatar Mar 22 '22 20:03 jeromelaban

/azp run

agneszitte avatar Aug 08 '22 16:08 agneszitte

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Aug 08 '22 16:08 azure-pipelines[bot]

@MartinZikmund there is some conflicts that needs to be resolved ;)

agneszitte avatar Sep 09 '22 15:09 agneszitte