Uno with Wpf Chinese code display messy code

[ywmoyue]

Current behavior

<Grid Background="{ThemeResource ApplicationPageBackgroundThemeBrush}"> <TextBlock Text="你好，世界!" Margin="20" FontSize="30" /> </Grid>

Expected behavior

Environment

Uno.UI / Uno.UI.Skia, Uno.UI.RemoteControl / Uno.WinUI.RemoteControl

Affected platforms

Skia (WPF)

IDE

Visual Studio 2019

IDE version

Microsoft Visual Studio Community 2019 16.11.2 Preview 1.0

Anything else we need to know?

I can set fontfamily for textblock and textbox controls to solve this problem, but setting fontfamily in contentdialog is invalid.

[Youssef1313]

Affects Gtk as well.

[JaiganeshKumaran]

@ywmoyue For ContentDialog, you can customise the TitleTemplate to change the used font.

[ywmoyue]

@ywmoyue For ContentDialog, you can customise the TitleTemplate to change the used font.

Thanks, I can use this method to solve the problem

[lindexi]

@jeromelaban Maybe I fix this by https://github.com/mono/SkiaSharp/pull/2146

Could you help me confirm this bug is fixed?

[jeromelaban]

@lindexi once there's a working build for the SkiaSharp PR, we'll be able to validate if that helps.

[lindexi]

@jeromelaban Thank you and My PR is merged. Could you help me confirm this bug is fixed?

[jeromelaban]

@lindexi you'll need to either wait for an official skia build to be released in preview. You can upgrade all SkiaSharp packages in your uno project once those are available.

[lindexi]

@jeromelaban Can I replace the output file ?

[lindexi]

Looks like this has not been fixed in SkiaSharp 2.88.3 version

[lindexi]

But I test the demo without UNO and I find the demo code work well. Demo code: https://github.com/lindexi/lindexi_gd/tree/0dc53049b7b74e57472408db161d2c066755bace/SkiaSharp/BihuwelcairkiDelalurnere

See https://github.com/mono/SkiaSharp/pull/2146

It seems that UNO still has bugs.

[jeromelaban]

Uno is not using SKTextBlob to render text, but rather HarfBuzz. How does an Uno app render text with your sample now?

[lindexi]

@Jaiganeshkumaran Thank you and I just replace the output file.

My demo code: https://github.com/lindexi/lindexi_gd/tree/08c2d7c8da65ffbb1d873a9f4fdb21304a9c2688/TestUnoIslands

[lindexi]

Yes, and I update it.

[jeromelaban]

Thanks. I see that your app is using an older version of Uno, and it is not updated to the latest version of SkiaSharp. Can you do this and post a screenshot again?

[lindexi]

@jeromelaban Yes, thank you. I'm worried that my testing method is wrong. Because my test method just replaces SkiaSharp.dll file

[lindexi]

@jeromelaban Sorry, the bug still exists after I updated to 4.5.14 version

My demo code: https://github.com/lindexi/lindexi_gd/tree/4b484190536c301f94ee574f36925155b4a9773c/TestUnoIslands

[jeromelaban]

Make sure to update SkiaSharp.

[lindexi]

@jeromelaban Can I add <PackageReference Include="SkiaSharp" Version="2.88.3" /> to update the SkiaSharp?

[lindexi]

Demo Code: https://github.com/lindexi/lindexi_gd/tree/613b6ec4fc7650fba9af341a090b653899d5cb63/TestUnoIslands

Thank you @jeromelaban

It is fixed !

[lindexi]

Uno is not using SKTextBlob to render text, but rather HarfBuzz. How does an Uno app render text with your sample now?

Sorry, I can not get your point at first. And I do not update the SkiaSharp.Harfbuzz at first.

[lindexi]

How to fix it?

1. Set the Chinese FontFamily to TextBlock
2. Update the SkiaSharp and SkiaSharp.Harfbuzz package

[jeromelaban]

Great thanks for the update!

[Youssef1313]

This works in Windows without changing the FontFamily. So if this is a requirement currently, then there is still a bug here.

[lindexi]

It display messy code without set the Chinese FontFamily.

[Youssef1313]

@lindexi But it works on UWP/WinUI right? Then I think this is still a bug @jeromelaban .

[lindexi]

@Youssef1313 It works well in UWP and WPF without set the FontFamily

[jeromelaban]

@lindexi whn you say WPF, do you mean an actual WPF app, not a Uno+WPF app? Either way, Skia is using the default system font at this point, and we'll probably fix this by switching to open-sans by default.

[lindexi]

@jeromelaban I mean the raw WPF application without uno.

[lindexi]

And I think we can set the global font by style. So it doesn't need to be repaired.