uno icon indicating copy to clipboard operation
uno copied to clipboard

`ScrollViewer` weirdly propagates its `TemplatedParent` to its `Content`

Open dr1rrb opened this issue 5 years ago • 3 comments

Current behavior

The ScrollViewer explicitly override the TemplatedParent of its Content in the ApplyScrollContentPresenterContent method.

If we remove this method, we might have a cyclic UI on iOS

Expected behavior

No patch

How to reproduce it (as minimally and precisely as possible)

Cf. linked bugs of https://github.com/unoplatform/uno/pull/3738 and https://github.com/unoplatform/uno/pull/3763 (When starting the Gallery project at commit 932e368, the app is stuck on the splashscreen on iOS)

Environment

Nuget Package: Uno.UI Package Version(s): 3.0 Affected platform(s):

  • [x] iOS
  • [ ] Android
  • [ ] WebAssembly
  • [ ] WebAssembly renderers for Xamarin.Forms
  • [ ] macOS
  • [ ] Windows
  • [ ] Build tasks
  • [ ] Solution Templates

dr1rrb avatar Aug 10 '20 04:08 dr1rrb

@morning4coffe-dev this may be fixed now with #17645 , can you check please?

MartinZikmund avatar Oct 09 '24 20:10 MartinZikmund

@MartinZikmund This seems to be iOS specific, do I have any way to test this without it?

morning4coffe-dev avatar Oct 12 '24 07:10 morning4coffe-dev

Not really, will check

MartinZikmund avatar Oct 14 '24 08:10 MartinZikmund

The relevant code that propagates the templated-parent was removed in #17645.

Not sure about the original problem that required this behavior/workaround, but it is been half a year since TP rework was completed and there is no report of SV related issue. I would assume it is safe to close this now.

Xiaoy312 avatar Feb 18 '25 16:02 Xiaoy312