uno
uno copied to clipboard
fix(macOS): app bundles must uses the Resources folder
GitHub Issue: closes https://github.com/unoplatform/uno/issues/20742
PR Type:
- ๐ Bugfix
What is the current behavior? ๐ค
The change to the Resources folder is made too late and some fonts are being loaded from the incorrect location, leading to crashes.
What is the new behavior? ๐
The logic was moved so it is executed earlier in the macOS host setup.
PR Checklist โ
Please check if your PR fulfills the following requirements:
- [ ] ๐ Commits must be following the Conventional Commits specification.
- [ ] ๐งช Added Runtime tests, UI tests, or a manual test sample for the changes have been added (for bug fixes / features) (if applicable)
- [ ] ๐ Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] ๐ผ๏ธ Validated PR
Screenshots Compare Test Runresults. - [ ] โ Contains NO breaking changes
Other information โน๏ธ
๐ค Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20760/docs/index.html
๐ค Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20760/wasm-skia-net9/index.html
The build 168096 found UI Test snapshots differences: android-28-net8: 19, android-28-net8-Snap: 37, ios: 3, ios-Snap: 40, skia-linux-screenshots: 70, skia-windows-screenshots: 324, wasm: 55, wasm-automated-net9.0-WinUI-Benchmarks-automated: 1, wasm-automated-net9.0-WinUI-Default-automated: 15, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 1, wasm-automated-net9.0-WinUI-RuntimeTests-2: 1
Details
-
android-28-net8: 19 changed over 824๐จ๐จ Comparison Details (first 20) ๐จ๐จ
FlyoutTest_When_NoOverlayInputPassThroughElement_Then_DontPassThrough_woOff_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElementProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_DynamicProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageWhen_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewerWhen_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touchDetereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75DoesNotInterfereWithHorizontalDrag_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerHorizontalScrollListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsWhen_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersButton_NestedButtons_Validation_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Nested_ButtonsUpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageDetereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRingWhen_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersDecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
-
android-28-net8-Snap: 37 changed over 1067๐จ๐จ Comparison Details (first 20) ๐จ๐จ
Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadiusBrushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipseGesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEventsListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsBorder_Border_Corner_Overlap_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerOverlapBorder_Border_Simple_No_Background_With_TextBox_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_TextBoxBrushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretchSwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2Image_Image_Stretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_NoneBorder_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThicknessListView_ListViewChangeViewArbitrary_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewChangeViewArbitraryRatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPageBorder_Border_CornerRadius_Alignments_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_AlignmentsBrushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigationMediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalUIElement_TransformToVisual_Simple_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_SimpleBorder_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_ClippingBorder_Border_Simple_No_Background_With_Content_Border_With_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_Content_Border_With_BackgroundScrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
-
ios: 3 changed over 255๐จ๐จ Comparison Details (first 20) ๐จ๐จ
Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_MeasureProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
ios-Snap: 40 changed over 984๐จ๐จ Comparison Details (first 20) ๐จ๐จ
Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGridButtons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplatePickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_ThemingBrushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfillBrushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrushBrushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretchBrushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransformBrushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrushColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPageGrid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_DefinitionsImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_HorizontalImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_VerticalImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControlImage_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_FormatsImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_SmallerImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_TallerImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_BiggerImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_WiderImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
-
skia-linux-screenshots: 70 changed over 2258๐จ๐จ Comparison Details (first 20) ๐จ๐จ
Gamepad_CurrentReading.png-darkGamepad_CurrentReading.pngButtons.pngButtonClippingTestsControl.png-darkClipboardTests.png-darkClipboardTests.pngDisplayInformation.png-darkDisplayInformation.pngGamepad_Enumeration.png-darkGamepad_Enumeration.pngExpanderColorValidationPage.png-darkExpanderColorValidationPage.pngFocus_FocusVisual_Properties.png-darkFocus_FocusVisual_Properties.pngImageIconPage.png-darkImageIconPage.pngImagesInlineInFlipView.png-darkImagesInlineInFlipView.pngExamples.png-darkExamples.png
-
skia-windows-screenshots: 324 changed over 2258๐จ๐จ Comparison Details (first 20) ๐จ๐จ
BitmapIcon_Foreground.pngBitmapIcon_Generic.png-darkBorderWithNullBrushAndNonZeroThickness.png-darkBorderWithNullBrushAndNonZeroThickness.pngBorder_CornerRadius_Clipping.png-darkBorder_CornerRadius_Clipping.pngButtonClippingTestsControl.png-darkCommandBar_Native_Frame.png-darkCommandBar_Native_Frame.pngCommandBar_Native_With_AppBarButton_With_Foreground.png-darkCommandBar_Native_With_AppBarButton_With_Foreground.pngContentDialog_Dialogs.png-darkContentDialog_Dialogs.pngGrid_ZIndex.png-darkGrid_ZIndex.pngAutoSuggestBox_SoftKeboard.png-darkBorder_CornerRadius_BorderThickness.png-darkBorder_CornerRadius_BorderThickness.pngDatePicker_VisualStates.png-darkDatePicker_VisualStates.png
-
wasm: 55 changed over 1051๐จ๐จ Comparison Details (first 20) ๐จ๐จ
UITests.Shared.Windows_UI.Xaml_Automation.AutomationProperties_AutomationIdUITests.Uno_Web.Http.CookieManagerTestsUITests.Windows_UI_Xaml_Controls.CommandBar.CommandBar_Native_With_TextBoxMUXControlsTestApp.SwipeControlPage2SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewIncrementalLoadingSamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_TextBoxUITests.Shared.Windows_UI_Xaml_Controls.Button.Overlapped_ButtonsUITests.Windows_UI_Xaml_Controls.SwipeControlTests.SwipeControl_ListView_ItemClickUno.UI.Samples.Content.UITests.CommandBar.CommandBar_With_Long_SentencesUITests.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DisabledUno.UI.Samples.Content.UITests.ButtonTestsControl.CheckBox_ButtonSamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_IsSelectedSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLegacySamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Padding_UnconstrainedUITests.Windows_UI_Xaml_Controls.ImageTests.SvgImageSource_FromMsAppDataSamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemsSourceSamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_BoundSelectedItemSamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Changing_TextUITests.Windows_UI_Xaml_Controls.Repeater.ItemsRepeater_NestedUno.UI.Samples.Content.UITests.FocusTests.FocusManagerTest
-
wasm-automated-net9.0-WinUI-Benchmarks-automated: 1 changed over 1๐จ๐จ Comparison Details (first 20) ๐จ๐จ
RunBenchmarks_Benchmarks_Shared_Controls_BenchmarkDotNetTestsPage
-
wasm-automated-net9.0-WinUI-Default-automated: 15 changed over 876๐จ๐จ Comparison Details (first 20) ๐จ๐จ
Default_StrokeThickness_MyLineDefault_StrokeThickness_MyPolylineDefault_StrokeThickness_MyEllipseSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageWhen_Padding_Is_Changed_Then_Cache_Is_Missed_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_MeasureCacheWhen_MaxLines_Then_AlignmentPositionIsCorrect_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_Two_With_WrapWhen_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersDefault_StrokeThickness_MyPolygonToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPageWhen_Theme_Changed_No_Crash_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_ThemingListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsWhen_TextTrimming_Is_Set_Then_Ellipsis_Is_Used_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_TextTrimmingDefault_StrokeThickness_MyRectTestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_FeaturesDefault_StrokeThickness_MyPath
-
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net9.0-WinUI-RuntimeTests-1: 1 changed over 1๐จ๐จ Comparison Details (first 20) ๐จ๐จ
RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage
-
wasm-automated-net9.0-WinUI-RuntimeTests-2: 1 changed over 1๐จ๐จ Comparison Details (first 20) ๐จ๐จ
RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage