uno icon indicating copy to clipboard operation
uno copied to clipboard

feat(import_external_docs): add support for contributor Git URLs

Open DevTKSS opened this issue 6 months ago • 4 comments

split from #20166 , should only add the new feature

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

  • the script is made for Uno Org. members which does have a branch normally on the uno repository.
  • therefore external Contributors like me which run the script to validate their PR to Uno OS Project e.g. docs are prompted by the current script, that the branch, they are naming to be imported for this, is (of course) not existing on the Uno (origin) repository which is defined in uno_git_url at the not-test script.
  • running it only for some of the externals to be imported causes the deployment of docfx and serve to fail as the links are invalid which it should generate

What is the new behavior?

As Uno is a Open Source Project and is welcoming Contributions as stated here this limitation should be eased, so these Validation can be done as requested locally with docfx serve e.g. before making a PR with running the CI/CD pipeline to validate e.g. links.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@jeromelaban PR split as requested?

Internal Issue (If applicable):

DevTKSS avatar May 30 '25 19:05 DevTKSS

@jeromelaban should it be expected that the fork name differs from the original?

DevTKSS avatar Jun 03 '25 06:06 DevTKSS

@jeromelaban should it be expected that the fork name differs from the original?

It can yes, you can account for it in the change.

jeromelaban avatar Jun 03 '25 11:06 jeromelaban

@jeromelaban The Docs entry should be the last point on the ToDo list here... I hope I done the conflict resulution is correct this way, but I am not sure about done it correct for the $remoteName in the not detached if clause. I migth got the script logic not fully correct 🤔 could someone please re-check on this?

DevTKSS avatar Jun 16 '25 20:06 DevTKSS

⚠️⚠️ The build 168579 has failed on Uno.UI - docs.

unodevops avatar Jun 16 '25 22:06 unodevops

⚠️⚠️ The build 168887 has failed on Uno.UI - docs.

unodevops avatar Jun 19 '25 18:06 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html

unodevops avatar Jun 19 '25 19:06 unodevops

@jeromelaban anything more to do here?

DevTKSS avatar Jul 01 '25 22:07 DevTKSS

@Jen-Uno Could you give me a state update for this?

DevTKSS avatar Jul 05 '25 18:07 DevTKSS

@booskander as your ci tool is on the import_external_docs.ps1 script, it would make sense to directly implement this maybe? that way it would just be one task and not another one after you completed to change your ci again

DevTKSS avatar Jul 07 '25 16:07 DevTKSS

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html

unodevops avatar Jul 08 '25 23:07 unodevops

@jeromelaban this is still looking for review and if all fine, to be merged

DevTKSS avatar Jul 19 '25 17:07 DevTKSS

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html

unodevops avatar Jul 19 '25 18:07 unodevops

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

github-actions[bot] avatar Sep 18 '25 02:09 github-actions[bot]

@jeromelaban looking for review to merge & close this PR, are here outstanding tasks except from syncing?

DevTKSS avatar Sep 18 '25 11:09 DevTKSS

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html

unodevops avatar Nov 13 '25 21:11 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html

unodevops avatar Nov 14 '25 14:11 unodevops

@jeromelaban could somebody maybe add a copilot instruction that it does not all the time suggest to put the $null -ne $parameterWeAreChecking ? It might be powershell best practice, but the whole codebase is written in C#, which stays with regular language usage like if (x is not null) and not like java script or whatever this was, to say if (null is not x) I mean... we are not in the Star Wars Universe and speaking like Yoda, aren't we ? 😅

DevTKSS avatar Nov 15 '25 17:11 DevTKSS

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html

unodevops avatar Nov 15 '25 18:11 unodevops