uno
uno copied to clipboard
feat(import_external_docs): add support for contributor Git URLs
split from #20166 , should only add the new feature
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
- Feature
What is the current behavior?
- the script is made for Uno Org. members which does have a branch normally on the uno repository.
- therefore external Contributors like me which run the script to validate their PR to Uno OS Project e.g. docs are prompted by the current script, that the branch, they are naming to be imported for this, is (of course) not existing on the Uno (origin) repository which is defined in uno_git_url at the not-test script.
- running it only for some of the externals to be imported causes the deployment of docfx and serve to fail as the links are invalid which it should generate
What is the new behavior?
As Uno is a Open Source Project and is welcoming Contributions as stated here this limitation should be eased, so these Validation can be done as requested locally with docfx serve e.g. before making a PR with running the CI/CD pipeline to validate e.g. links.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Runresults. - [x] Contains NO breaking changes
- [ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [x] Commits must be following the Conventional Commits specification.
Other information
@jeromelaban PR split as requested?
Internal Issue (If applicable):
@jeromelaban should it be expected that the fork name differs from the original?
@jeromelaban should it be expected that the fork name differs from the original?
It can yes, you can account for it in the change.
@jeromelaban The Docs entry should be the last point on the ToDo list here... I hope I done the conflict resulution is correct this way, but I am not sure about done it correct for the $remoteName in the not detached if clause. I migth got the script logic not fully correct 🤔 could someone please re-check on this?
⚠️⚠️ The build 168579 has failed on Uno.UI - docs.
⚠️⚠️ The build 168887 has failed on Uno.UI - docs.
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html
@jeromelaban anything more to do here?
@Jen-Uno Could you give me a state update for this?
@booskander as your ci tool is on the import_external_docs.ps1 script, it would make sense to directly implement this maybe? that way it would just be one task and not another one after you completed to change your ci again
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html
@jeromelaban this is still looking for review and if all fine, to be merged
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.
@jeromelaban looking for review to merge & close this PR, are here outstanding tasks except from syncing?
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html
@jeromelaban could somebody maybe add a copilot instruction that it does not all the time suggest to put the $null -ne $parameterWeAreChecking ? It might be powershell best practice, but the whole codebase is written in C#, which stays with regular language usage like if (x is not null) and not like java script or whatever this was, to say if (null is not x) I mean... we are not in the Star Wars Universe and speaking like Yoda, aren't we ? 😅
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20667/docs/index.html