uno
uno copied to clipboard
Published
20 hours ago •
unoplatform
unoplatform
IDE Channel Client: Have a generic OnMessageReceived
GitHub Issue (If applicable): closes: #18448
PR Type
What kind of change does this PR introduce?
- Refactoring (no functional changes, no api changes)
What is the current behavior?
We have several messages and events on the IDEChannelClient.
What is the new behavior?
Now we only have one, and the messages are being handled by the EntryPoint.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Runresults. - [ ] Contains NO breaking changes
- [ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [ ] Commits must be following the Conventional Commits specification.
Other information
Internal Issue (If applicable):
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18501/index.html
The build 144023 found UI Test snapshots differences: android-28-net8: 21, android-28-net8-Snap: 45, ios: 9, ios-Snap: 48, skia-gtk-screenshots: 69, skia-linux-screenshots: 63, skia-windows-screenshots: 63, wasm: 423, wasm-automated-net9.0-UWP-Default-automated: 25, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0
Details
-
android-28-net8: 21 changed over 829🚨🚨 Comparison Details (first 20) 🚨🚨
Button_OverlappedButtons_UITests_Shared_Windows_UI_Xaml_Controls_Button_Overlapped_ButtonsDetereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50FlyoutTest_Unloaded_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_UnloadedFlyoutTest_When_NoOverlayInputPassThroughElement_Then_DontPassThrough_woAuto_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElementProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewerWhen_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touchDecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageDatePicker_PickerFlyout_PlacementstopLeft_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_PlacementDetereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220SelectionOnLoad_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsInitialLoadSelectedSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageTextBox_DeleteButton_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_DeleteButton_AutomatedUpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageValidateResourceLoader_Simple_UITests_Shared_Windows_ApplicationModel_Resources_ResourceLoader_ResourceLoader_SimpleWhen_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
-
android-28-net8-Snap: 45 changed over 1066🚨🚨 Comparison Details (first 20) 🚨🚨
ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsSlider_Slider_Features_UITests_Shared_Windows_UI_Xaml_Controls_Slider_Slider_FeaturesSlider_Slider_Frequency_Uno_UI_Samples_Content_UITests_Slider_Slider_FrequencySlider_Slider_Inside_ListViewHeader_Uno_UI_Samples_Content_UITests_Slider_Slider_Inside_ListViewHeaderTextBlock_TextBlock_Span_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_SpanTextBlock_TextBlock_Style_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Style_InheritanceTextBlock_TextBlock_TextAlignment_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_TextAlignmentTabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPageNavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4PageTextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_RunTextBlock_TextBlock_FontWeight_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FontWeightTextBlock_TextBlock_LineHeight_Multiline_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_MultilineTextBlock_TextBlock_LineHeight_TextAlignment_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_TextAlignmentMediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_ExtensionMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_ExtensionScrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPageMUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPageScrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPageWebView_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title
-
ios: 9 changed over 267🚨🚨 Comparison Details (first 20) 🚨🚨
FlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withOff_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElementProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220FlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withOn_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElementProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersTextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_BindingsFlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withAuto_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElementWhen_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
-
ios-Snap: 48 changed over 1057🚨🚨 Comparison Details (first 20) 🚨🚨
Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretchButtons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplateContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParentMediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_SourcesBrushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransformBrushes_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_Fallback_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_FallbackTextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_RunBrushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2Grid_Grid_with_UserControl_VerticalAlignment_Fixed_Height_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UserControl_VerticalAlignment_Fixed_HeightImage_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_FormatsImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControlImage_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsNavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSampleRelativePanel_UITests_Windows_UI_Xaml_Controls_RelativePanelTests_RelativePanel_MultipleCenterAlign_UITests_Windows_UI_Xaml_Controls_RelativePanelTests_RelativePanel_MultipleCenterAlignShapes_UITests_Windows_UI_Xaml_Shapes_Ellipse_Positioning_UITests_Windows_UI_Xaml_Shapes_Ellipse_PositioningTextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanelBrushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelayImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_HorizontalListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
-
skia-gtk-screenshots: 69 changed over 2220🚨🚨 Comparison Details (first 20) 🚨🚨
Path_Geometries.png-darkPath_Geometries.pngUIElement_Layout_Bug2879.png-darkUIElement_Layout_Bug2879.pngTransformToVisual_Simple.png-darkTransformToVisual_Simple.pngEllipse.png-darkImageIconPage.png-darkDropDownButtonPage.png-darkExpanderColorValidationPage.pngDropDownButtonPage.pngImageInStackPanel.png-darkImageInStackPanel.pngNetworkInformation.png-darkNetworkInformation.pngEllipse.pngGamepad_CurrentReading.png-darkCalendarView_Theming.png-darkImageBrushStretch2.pngGamepad_CurrentReading.png
-
skia-linux-screenshots: 63 changed over 2220🚨🚨 Comparison Details (first 20) 🚨🚨
BorderImageBrush.png-darkBorderImageBrush.pngDisplayInformation.png-darkDisplayInformation.pngGamepad_CurrentReading.png-darkGamepad_CurrentReading.pngClipboardTests.png-darkClipboardTests.pngCalendarView_Theming.png-darkFocus_FocusVisual_Properties.png-darkFocus_FocusVisual_Properties.pngImageInStackPanel.png-darkImageInStackPanel.pngBorderImageBrushRelativeTransform.png-darkBorderImageBrushRelativeTransform.pngImageBrush_UniformToFill.png-darkImageBrush_UniformToFill.pngImageIconPage.png-darkImageIconPage.pngImage_UseTargetSize.png-dark
-
skia-windows-screenshots: 63 changed over 2220🚨🚨 Comparison Details (first 20) 🚨🚨
ClipboardTests.png-darkClipboardTests.pngDisplayInformation.png-darkDisplayInformation.pngFocus_FocusVisual_Properties.png-darkGamepad_Enumeration.png-darkFocus_FocusVisual_Properties.pngGamepad_Enumeration.pngAppWindowPositionAndSize.pngCalendarView_Theming.png-darkColorPickerSample.png-darkColorPickerSample.pngEllipse.png-darkEllipse.pngButtons.pngBorderImageBrush.png-darkButtonClippingTestsControl.pngAppWindowPositionAndSize.png-darkBorderImageBrush.pngImageInStackPanel.png-dark
-
wasm: 423 changed over 1044🚨🚨 Comparison Details (first 20) 🚨🚨
GenericApp.Views.Content.UITests.ContentControlTestsControl.ContentControl_UnsetContentGenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionModeMUXControlsTestApp.NavigationViewStretchPageMUXControlsTestApp.RefreshContainerOnImagePageMUXControlsTestApp.SwipeControlPageSamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigateToUriSamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemTemplateSamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.Picker_ResizableSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedChangingSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedEmptySamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewVariableItemHeightSamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.AutoSizedPathCenteredSamplesApp.Windows_UI_Xaml_Shapes.PolygonPageSamplesApp.Windows_UI_Xaml_Shapes.PolylinePageUITests.Shared.Microsoft_UI_Xaml_Controls.RadioMenuFlyoutItemTests.RadioMenuFlyoutItemPageUITests.Shared.Microsoft_UI_Xaml_Controls.TreeViewTests.TreeViewPageUITests.Shared.Microsoft_UI_Xaml_Controls.TwoPaneViewTests.TwoPaneViewPageUITests.Shared.Windows_UI_Xaml.Clipping.ClippingToControlBoundsUITests.Shared.Windows_UI_Xaml.Clipping.ClippingWithOpacityUITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_Content_ThemeResource
-
wasm-automated-net9.0-UWP-Default-automated: 25 changed over 1946🚨🚨 Comparison Details (first 20) 🚨🚨
Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSourceAutomation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_NameDefault_StrokeThickness_MyLineDefault_StrokeThickness_MyPolylineListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsBrushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrushExpander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPageBrushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipseMediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalDefault_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelectedMediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_SourcesMediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_ExtensionMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_ExtensionListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsWebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_BasicWhen_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_Theme_Changed_No_Crash_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_ThemingSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageTestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
-
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1 -
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1 -
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1
backport release/stable/5.5
✅ Backports have been created
- #18534 IDE Channel Client: Have a generic OnMessageReceived (backport #18501) has been created for branch
release/stable/5.5
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}