uno icon indicating copy to clipboard operation
uno copied to clipboard

fix(ios): Tabview Selection when Bindings items

Open ajpinedam opened this issue 1 year ago • 11 comments

GitHub Issue (If applicable): closes https://github.com/unoplatform/ziidms-private/issues/23

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Using TabView with bound items and changing the SelectedItem is causing the TabView Tabs to display incorrectly.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

ajpinedam avatar Oct 16 '24 17:10 ajpinedam

todo @ajpinedam:

  • [x] sanity-check for android
  • [x] create an issue for reminder to restore the bring-into-view that we disabled for out-of-screen items (ios and possibly droid)

Xiaoy312 avatar Oct 16 '24 21:10 Xiaoy312

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 17 '24 05:10 unodevops

todo @ajpinedam:

* [x]  sanity-check for android

* [x]  create an issue for reminder to restore the bring-into-view that we disabled for out-of-screen items (ios and _possibly droid_)

Validated Android and the issue fixed here is absent in Android. But the BringIntoView is not working correctly there. TabViewItem is selected but not made visible.

Follow-up ticket: https://github.com/unoplatform/uno/issues/18499

ajpinedam avatar Oct 17 '24 05:10 ajpinedam

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 17 '24 05:10 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 17 '24 05:10 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 17 '24 15:10 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 17 '24 16:10 unodevops

/azp run

ajpinedam avatar Oct 18 '24 02:10 ajpinedam

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Oct 18 '24 02:10 azure-pipelines[bot]

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 18 '24 02:10 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 18 '24 02:10 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 20 '24 16:10 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 20 '24 16:10 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 21 '24 20:10 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 21 '24 20:10 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 22 '24 02:10 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18492/index.html

unodevops avatar Oct 22 '24 04:10 unodevops

@mergifyio backport release/stable/5.5

jeromelaban avatar Oct 22 '24 17:10 jeromelaban

backport release/stable/5.5

✅ Backports have been created

mergify[bot] avatar Oct 22 '24 17:10 mergify[bot]