uno icon indicating copy to clipboard operation
uno copied to clipboard

fix: Fix Binding that should be treated as regular property

Open Youssef1313 opened this issue 1 year ago • 5 comments

GitHub Issue (If applicable): closes #18345

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Youssef1313 avatar Oct 01 '24 06:10 Youssef1313

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18346/index.html

unodevops avatar Oct 01 '24 06:10 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18346/index.html

unodevops avatar Oct 01 '24 06:10 unodevops

This PR needs IsPropMethodCall to be completed. The reason this is needed is that now Control.TabNavigation bindings are broken, because we are declaring it this way:

image

This means, the DP registry doesn't really have a property with name TabNavigation. On WinUI, the property is actually registered, and is marked as IsPropMethodCall so that it can delegate to TabFocusNavigation.

Youssef1313 avatar Oct 01 '24 12:10 Youssef1313

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18346/index.html

unodevops avatar Oct 01 '24 12:10 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18346/index.html

unodevops avatar Oct 01 '24 13:10 unodevops

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

github-actions[bot] avatar Feb 15 '25 02:02 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Feb 25 '25 02:02 github-actions[bot]