uno
uno copied to clipboard
fix: Update `ProgressRing` styles to match WinUI
GitHub Issue (If applicable): closes #18011
PR Type
What kind of change does this PR introduce?
- Bugfix
What is the current behavior?
The ProgressRing uses old styles to render with Fluent design.
What is the new behavior?
The ProgressRing is matching the fluent style.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Runresults. - [x] Contains NO breaking changes
- [x] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [x] Commits must be following the Conventional Commits specification.
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18018/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18018/index.html
The build 137418 found UI Test snapshots differences: android-28-net8: 20, android-28-net8-Snap: 49, ios: 7, ios-Snap: 30, skia-gtk-screenshots: 22, skia-linux-screenshots: 21, skia-windows-screenshots: 47, wasm: 329, wasm-automated-net8.0-UWP-Default-automated: 16, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 0, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0
Details
-
android-28-net8: 20 changed over 832🚨🚨 Comparison Details (first 20) 🚨🚨
Button_OverlappedButtons_UITests_Shared_Windows_UI_Xaml_Controls_Button_Overlapped_ButtonsDecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageDetereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRingDetereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsNativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_DynamicNavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSampleWebView_NavigateToAnchor_InitialWebView_NavigateToLongString_AfterSuccessDetereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewerWhen_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touchDetereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_NoneWhen_SingleItem_UITests_Windows_UI_Xaml_Controls_SwipeControlTests_SwipeControl_AutomatedSelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPageSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
-
android-28-net8-Snap: 49 changed over 1065🚨🚨 Comparison Details (first 20) 🚨🚨
Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Margin_On_Container_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Margin_On_ContainerIcons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_ForegroundListView_ListViewDynamicOrientation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewDynamicOrientationNavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPageScrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPageTextBox_Input_InputScope_PersonalFullName_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_PersonalFullNameTextBox_Input_InputScope_PhoneNumber_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_PhoneNumberTextBox_Input_InputScope_Search_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_SearchListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_TemplatesMUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageMUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPageGesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEventsListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_MeasureMediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_ExtensionMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_ExtensionTeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPageScrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPageToggleSwitch_ToggleSwitch_Header_UITests_Shared_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_HeaderToggleSwitch_ToggleSwitch_IsOn_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_ToggleSwitch_IsOn
-
ios: 7 changed over 268🚨🚨 Comparison Details (first 20) 🚨🚨
When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGroupedTextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_BindingsWhen_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
ios-Snap: 30 changed over 1056🚨🚨 Comparison Details (first 20) 🚨🚨
Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrushClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClippingMediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalBrushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFillDefault_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigationBrushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretchBrushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGridBrushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransformBrushes_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInListGrid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildrenImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_BiggerImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_EqualListView_ListViewHeaderFooterOnly_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooterOnlyGrid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_DefinitionsImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_VerticalImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControlBrushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXYImage_Image_Stretch_None_ScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None_ContainersListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
-
skia-gtk-screenshots: 22 changed over 2216🚨🚨 Comparison Details (first 20) 🚨🚨
RectanglemaskingRectangleGrid.pngBorderImageBrushRelativeTransform.png-darkBorderImageBrushRelativeTransform.pngImageBrushStretch2.pngUsing .ogg.png-darkUsing .ogg.pngImageBrush_UniformToFill.pngRectangle.png-darkRectangle.pngImageBrushAlignmentXY2.png-darkImageBrushAlignmentXY2.pngImageBrushChangingCornerRadius.pngBorderImageBrush.png-darkBorderImageBrush.pngPath_Geometries.png-darkPath_Geometries.pngPasswordBox_AutoFill.png-darkPasswordBox_AutoFill.pngMini player.png-darkMini player.png
-
skia-linux-screenshots: 21 changed over 2216🚨🚨 Comparison Details (first 20) 🚨🚨
Ellipse.png-darkEllipse.pngImageBrush_SameWithDelay.png-darkImageBrush_SameWithDelay.pngImage_Stretch_None.png-darkImage_Stretch_None.pngImage_UseTargetSize.png-darkImage_UseTargetSize.pngImagesInlineInFlipView.png-darkImagesInlineInFlipView.pngEllipsemaskingEllipseSuperpositionPanel.pngImageBrushInList.png-darkImageBrushInList.pngRectangleStretchFill.png-darkRectangleStretchFill.pngMini player.png-darkMini player.pngImageWithLateSourceUniformToFill.png-darkImageWithLateSourceUniformToFill.pngUsing .ogg.png-dark
-
skia-windows-screenshots: 47 changed over 2216🚨🚨 Comparison Details (first 20) 🚨🚨
DoubleImageBrushInList.png-darkDoubleImageBrushInList.pngBorderImageBrushRelativeTransform.pngImagesInlineInFlipView.png-darkImagesInlineInFlipView.pngImageSourceUrlMsAppDataScheme.png-darkImageSourceUrlMsAppDataScheme.pngBorderImageBrushRelativeTransform.png-darkImageBrushInList.png-darkImageBrushInList.pngImageWithLateSourceUniformToFill.png-darkImageWithLateSourceUniformToFill.pngImage_Stretch_None_ScrollViewer.png-darkImage_Stretch_None_ScrollViewer.pngImage_UseTargetSize.png-darkImage_UseTargetSize.pngImageBrush_UniformToFill.png-darkImageBrush_UniformToFill.pngImageIconPage.png-darkImageIconPage.png
-
wasm: 329 changed over 1043🚨🚨 Comparison Details (first 20) 🚨🚨
GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionModeMUXControlsTestApp.HierarchicalNavigationViewMarkupMUXControlsTestApp.NavigationViewIsPaneOpenPageMUXControlsTestApp.SwipeControlClearPageSamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_Pane_AutomatedSamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_CornerRadiusSamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemContainerStyleSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLargeHeaderSamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemContainerStyleSelectorSamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathResizeTestSamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathScrollViewerSamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathTimeUITests.Shared.Windows_UI_Xaml.Clipping.ClippingToControlBoundsUITests.Shared.Windows_UI_Xaml_Controls.Popup.Popup_LightDismissUITests.Shared.Windows_UI_Xaml_Controls.Popup.Popup_Overlay_OnUITests.Toolkit.ElevatedView_LevelsUITests.Windows_UI_Xaml_Controls.CalendarView.CalendarDatePicker_DescriptionUITests.Windows_UI_Xaml_Controls.ListView.ListViewItem_IsEnabledUITests.Windows_UI_Xaml_Controls.ListView.ListView_DuplicateItemUITests.Windows_UI_Xaml_Controls.TextBox.TextBox_Wrapping
-
wasm-automated-net8.0-UWP-Default-automated: 16 changed over 1952🚨🚨 Comparison Details (first 20) 🚨🚨
Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadiusDefault_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelectedListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_MeasureMediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_ExtensionListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsTestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_FeaturesWhen_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageWindows_Media_MediaPlayer_UITests_Windows_Media_MediaPlayerTestsWriteableBitmap_Invalidate_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_ImageSourceWriteableBitmapInvalidate
-
wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net8.0-UWP-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1 -
wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1