Desktop will always build as WinEXE

[dansiegel]

trafficstars

GitHub Issue (If applicable): closes #

• closes #17719

PR Type

What kind of change does this PR introduce?

• Bugfix

What is the current behavior?

We limit the WinEXE Output Type to when we are building a release

What is the new behavior?

We always use WinEXE for the Output Type of the Desktop Target for an Uno Head project. cc: @jeromelaban

[unodevops]

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html

[unodevops]

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html

[Youssef1313]

/azp run (net8_uwp_runtimetests_group_01 was stuck even with re-tries) - artifacts of the previous build (https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=136760&view=artifacts&pathAsName=false&type=publishedArtifacts)

[azure-pipelines[bot]]

Azure Pipelines successfully started running 2 pipeline(s).

[azure-pipelines[bot]]

No pipelines are associated with this pull request.

[unodevops]

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html

[unodevops]

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html

[nventive-devops]

The build 136979 found UI Test snapshots differences: android-28-net8: 20, android-28-net8-Snap: 55, ios: 7, ios-Snap: 38, skia-gtk-screenshots: 31, skia-linux-screenshots: 24, skia-windows-screenshots: 22, wasm: 381, wasm-automated-net8.0-UWP-Default-automated: 18, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 0, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0

Details

• android-28-net8: 20 changed over 832

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
  • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
  • FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ListViewItem_-_2_-_Click_outside
  • FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
  • FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ListViewItem_-_1_-_Initial_State
  • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
  • NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
  • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
  • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
  • PasswordBox_AutoGrow_Horizontally_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Simple
  • TextBox_CharacterCasingLower_ShouldBeAllLower_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_CharacterCasing
  • NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
  • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
  • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
  • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
  • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
  • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
  • WebView_NavigateToLongString_AfterSuccess
  • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
  • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems

• android-28-net8-Snap: 55 changed over 1065

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
  • ItemsRepeater_UITests_Windows_UI_Xaml_Controls_Repeater_StackLayout_Simple_UITests_Windows_UI_Xaml_Controls_Repeater_StackLayout_Simple
  • ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading
  • ListView_ListView_ItemClick_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_ItemClick
  • ListView_ListView_ItemContainerStyleSelector_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_ItemContainerStyleSelector
  • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
  • MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage
  • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
  • ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
  • Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
  • Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
  • ListView_ListViewVariableItemHeight_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewVariableItemHeight
  • MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
  • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
  • GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest
  • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
  • Shapes_UITests_Windows_UI_Xaml_Shapes_Path_Geometries_UITests_Windows_UI_Xaml_Shapes_Path_Geometries
  • Shapes_UITests_Windows_UI_Xaml_Shapes_Rectangle_Rounding_UITests_Windows_UI_Xaml_Shapes_Rectangle_Rounding
  • NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
  • NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage

• ios: 7 changed over 268

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
  • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
  • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
  • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220

• ios-Snap: 38 changed over 1056

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • ListView_ListViewStackPanel_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewStackPanel
  • NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
  • Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
  • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
  • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
  • Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
  • Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
  • ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
  • SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
  • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
  • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
  • TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
  • Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
  • Brushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransform
  • Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
  • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
  • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
  • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
  • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
  • TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel

• skia-gtk-screenshots: 31 changed over 2216

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • ImageInStackPanel.png-dark
  • ImageInStackPanel.png
  • RectanglemaskingRectangleGrid.png
  • TransformToVisual_Simple.png-dark
  • TransformToVisual_Simple.png
  • Image_Stretch_None_ScrollViewer.png-dark
  • Image_Stretch_None_ScrollViewer.png
  • ImageBrushChangingCornerRadius.png
  • ImageBrushStretch2.png
  • UIElement_ContextFlyout.png-dark
  • UIElement_ContextFlyout.png
  • BorderImageBrushRelativeTransform.png-dark
  • BorderImageBrushRelativeTransform.png
  • StretchNoneBoundingBoxInDoubleStackPanel.png-dark
  • StretchNoneBoundingBoxInDoubleStackPanel.png
  • Using .ogg.png-dark
  • Using .ogg.png
  • Native.png-dark
  • Native.png
  • Rectangle.png-dark

• skia-linux-screenshots: 24 changed over 2216

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • BorderImageBrushRelativeTransform.png-dark
  • BorderImageBrushRelativeTransform.png
  • Image_UseTargetSize.png-dark
  • Image_UseTargetSize.png
  • DoubleImageBrushInList.png-dark
  • DoubleImageBrushInList.png
  • LargeImageList.png-dark
  • LargeImageList.png
  • ImageBrush_SameWithDelay.png-dark
  • ImageBrush_SameWithDelay.png
  • Mini player.png-dark
  • Mini player.png
  • ListView_IsSelected.png-dark
  • ListView_IsSelected.png
  • ImageWithLateSourceUniformToFill.png-dark
  • ImageWithLateSourceUniformToFill.png
  • Rectangle.png-dark
  • Rectangle.png
  • StretchNoneBoundingBoxInDoubleStackPanel.png-dark
  • StretchNoneBoundingBoxInDoubleStackPanel.png

• skia-windows-screenshots: 22 changed over 2216

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • AppWindowPositionAndSize.png-dark
  • AppWindowPositionAndSize.png
  • Image_UseTargetSize.png-dark
  • ImageSourceUrlMsAppDataScheme.png-dark
  • Image_UseTargetSize.png
  • ImageSourceUrlMsAppDataScheme.png
  • Ellipse.png-dark
  • Ellipse.png
  • ImageBrushInList.png-dark
  • ImageBrushInList.png
  • ImageBrush_UniformToFill.png-dark
  • ImageBrush_UniformToFill.png
  • DoubleImageBrushInList.png-dark
  • DoubleImageBrushInList.png
  • NavigationViewCustomThemeResourcesPage.png-dark
  • NavigationViewCustomThemeResourcesPage.png
  • Mini player.png-dark
  • Mini player.png
  • Rectangle.png-dark
  • Rectangle.png

• wasm: 381 changed over 1043

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • GenericApp.Views.Samples.Shared.Content.UITests.GridViewGrouped
  • initial_state
  • MUXControlsTestApp.NavigationViewIsPaneOpenPage
  • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Corners
  • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_PlaceholderText
  • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Popover
  • SamplesApp.Windows_UI_Xaml.Clipping.ButtonClippingTestsControl
  • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Image
  • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformHorizontalAlignmentCenter
  • UITests.Microsoft_UI_Xaml_Controls.InfoBadgeTests.InfoBadgePage
  • UITests.Shared.Wasm.Wasm_CustomEvent
  • UITests.Shared.Windows_ApplicationModel.Calls.PhoneCallHistoryEntryReaderTests
  • UITests.Shared.Windows_ApplicationModel.Calls.PhoneCallManagerTests
  • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Margin_On_Container
  • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_ObservableCollection_Unused_Space
  • UITests.Shared.Windows_UI_Xaml_Controls.ToolTip.TextOnlyToolTipSample
  • UITests.Shared.Windows_UI_Xaml_Controls.WebView.WebView_NavigateToString2
  • UITests.Windows_UI_ViewManagement.UISettingsTests
  • UITests.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Stretch
  • UITests.Windows_UI_Xaml_Controls.CommandBar.BackButtonTitle.CommandBar_Frame

• wasm-automated-net8.0-UWP-Default-automated: 18 changed over 1952

  🚨🚨 Comparison Details (first 20) 🚨🚨

  • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
  • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
  • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
  • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
  • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
  • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
  • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
  • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
  • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
  • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
  • Windows_Media_MediaPlayer_UITests_Windows_Media_MediaPlayerTests
  • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
  • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

• wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1

• wasm-automated-net8.0-UWP-RuntimeTests-1: 0 changed over 1

• wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1

• wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1

• wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1

• wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1

• wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1

[rajamatt]

@agneszitte I tried overriding Uno with this change and launched a newly created 5.3 & latest 5.4 dev apps but the console still appears on Desktop skia on Windows. I'm guessing nuget overriding Uno might not be overriding the actual Uno.Sdk project... Not sure how to test this one. Seeing as this PR is labelled draft it might be best to wait on it.

[jeromelaban]

@rajamatt you need to use the packages from the CI, overriding from a local build will not work. You can also test the changes in the cache directly, but it's a manual operation.

[rajamatt]

Just managed to test this and it is working. I created a blank unoapp with Uno.SDK 5.3.99, replaced the SDK with the one from the CI.

We always use WinEXE for the Output Type of the Desktop Target for an Uno Head project.

As written in the description of the PR now all OutputTypes (both WinExe and Exe) don't show a console on Windows.

To compare with the current version, I created another blank unoapp with 5.3.99 but this time I didn't touch the SDK. The <OutputType> seems to be working fine. With <OutputType>Exe</OutputType> the Skia console appears and with <OutputType>WinExe</OutputType> it doesn't appear. Maybe this was fixed by something else.

cc: @jeromelaban

[unodevops]

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html

[unodevops]

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html

[unodevops]

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17974/index.html

[unodevops]

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17974/index.html

[jeromelaban]

@mergifyio backport release/stable/5.4

[mergify[bot]]

backport release/stable/5.4

✅ Backports have been created

• #18376 Adjust devserver inclusion when WinExe is selected (backport #17974) has been created for branch release/stable/5.4