uno
uno copied to clipboard
fix: Ensure `Border.Child` is measured/arranged when reset
GitHub Issue (If applicable): closes #1046
PR Type
What kind of change does this PR introduce?
- Bugfix
What is the current behavior?
Re-setting Border.Child to the same reference does not do anything.
What is the new behavior?
Measure/Arrange are triggered on the Child as it is temporarily removed and re-added
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [x] Validated PR
Screenshots Compare Test Runresults. - [x] Contains NO breaking changes
- [x] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [x] Commits must be following the Conventional Commits specification.
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17860/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17860/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17860/index.html
@MartinZikmund looks like it's failing: https://dev.azure.com/uno-platform/Uno%20Platform/_TestManagement/Runs?runId=2996313&_a=resultSummary&resultId=102934
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17860/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17860/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17860/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17860/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17860/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17860/index.html
The build 138022 found UI Test snapshots differences: android-28-net8: 25, android-28-net8-Snap: 57, ios: 5, ios-Snap: 45, skia-gtk-screenshots: 25, skia-linux-screenshots: 22, skia-windows-screenshots: 28, wasm: 437, wasm-automated-net8.0-UWP-Default-automated: 640, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 0, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0
Details
-
android-28-net8: 25 changed over 832🚨🚨 Comparison Details (first 20) 🚨🚨
Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50ListView_ListViewVariableItemHeightLong_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewVariableItemHeightLongProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageRadioButtons_Disable_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_RadioButton_IsEnabled_AutomatedDetereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25PopupWithOverlay_AfterSelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPageSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageTextBox_Selection_IsReadOnly_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_SelectionWebView_NavigateToLongString_AfterSuccessFlyoutTest_DataBoundButton_CommandExecutes_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_ButtonInContentDecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPageWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewerWhen_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touchDetereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageUpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
-
android-28-net8-Snap: 57 changed over 1065🚨🚨 Comparison Details (first 20) 🚨🚨
Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_BasicMediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalGesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_Manipulation_Basics_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_Manipulation_BasicsIcons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPageListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoadingNavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPageImage_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStreamMUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageTeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPageListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_TemplatesMediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_ExtensionMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_ExtensionTextBlock_TextBlock_LineHeight_Inlines_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_InlinesTextBlock_TextBlock_Nested_Measure_With_Outer_Alignments_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Nested_Measure_With_Outer_AlignmentsListView_ListViewScrollBar_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewScrollBarRatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPageTextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_LayoutScrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPageTextBlock_TextBlock_Inlines_TemplatedParent_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Inlines_TemplatedParent
-
ios: 5 changed over 268🚨🚨 Comparison Details (first 20) 🚨🚨
Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_MeasureTextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_BindingsSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
ios-Snap: 45 changed over 1056🚨🚨 Comparison Details (first 20) 🚨🚨
MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalBrushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFillListView_ListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedListView_ListViewHeaderFooter_ImplicitlyBinded_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooter_ImplicitlyBindedShapes_UITests_Windows_UI_Xaml_Shapes_Ellipse_StrokeThickness_UITests_Windows_UI_Xaml_Shapes_Ellipse_StrokeThicknessIcons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPageSwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretchImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_BiggerImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_EqualImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_SmallerListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGroupedImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_TallerListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_MeasureNavigationView_MUXControlsTestApp_NavigationViewMinimalPage_MUXControlsTestApp_NavigationViewMinimalPageImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_HorizontalTextBlock_Attributed_text_FontSize_Changing_Uno_UI_Samples_Content_UITests_TextBlockControl_Attributed_text_FontSize_ChangingTextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChangingBrushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransformBrushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
-
skia-gtk-screenshots: 25 changed over 2216🚨🚨 Comparison Details (first 20) 🚨🚨
RectangleStretchFill.pngCalendarView_Theming.png-darkCalendarView_Theming.pngImageBrushAlignmentXY.pngMini player.png-darkMini player.pngImageOpened.pngWindow_SetBackground.png-darkWindow_SetBackground.pngImageBrushAlignmentXY2.png-darkImageBrushAlignmentXY2.pngPanelImageBrush.png-darkPanelImageBrush.pngImageBrush_UniformToFill.pngImageIconPage.png-darkImageIconPage.pngBorderImageBrushRelativeTransform.png-darkBorderImageBrushRelativeTransform.pngStretchNoneBoundingBoxInDoubleStackPanel.png-darkStretchNoneBoundingBoxInDoubleStackPanel.png
-
skia-linux-screenshots: 22 changed over 2216🚨🚨 Comparison Details (first 20) 🚨🚨
ImageBrush_UniformToFill.png-darkImageBrush_UniformToFill.pngImageIconPage.png-darkImageIconPage.pngImageBrushStretch.png-darkImageBrushStretch.pngBorderImageBrushRelativeTransform.png-darkBorderImageBrushRelativeTransform.pngCalendarView_Theming.pngEllipse.png-darkEllipse.pngCalendarView_Theming.png-darkListView_Weird_Measure.png-darkListView_Weird_Measure.pngMini player.png-darkMini player.pngSwipeControlPage2.png-darkSwipeControlPage2.pngPathImageBrushfill.png-darkPathImageBrushfill.png
-
skia-windows-screenshots: 28 changed over 2216🚨🚨 Comparison Details (first 20) 🚨🚨
AppWindowPositionAndSize.png-darkCalendarView_Theming.pngBorderImageBrush.pngBorderImageBrushRelativeTransform.png-darkBorderImageBrushRelativeTransform.pngEllipse.png-darkEllipse.pngBorderImageBrush.png-darkAppWindowPositionAndSize.pngCalendarView_Theming.png-darkImagesInlineInFlipView.png-darkImagesInlineInFlipView.pngImageSourceUrlMsAppDataScheme.png-darkImageSourceUrlMsAppDataScheme.pngMini player.png-darkMini player.pngSwipeControlPage2.png-darkSwipeControlPage2.pngRectangle.png-darkRectangle.png
-
wasm: 437 changed over 1043🚨🚨 Comparison Details (first 20) 🚨🚨
Benchmarks.Shared.Controls.BenchmarkDotNetTestsPageMUXControlsTestApp.NavigationViewMinimalPageMUXControlsTestApp.NavigationViewTopNavOverflowButtonPageMUXControlsTestApp.NavigationViewTopNavPageSamplesApp.Samples.UnitTests.HttpUnitTestsSamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_BasicNavigationSamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.Picker_ResizableSamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelectedSamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListViewTestSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLargeLegacySamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.FixedWidthUniformSamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformAutoSizeUITests.Microsoft_UI_Xaml_Controls.AnimatedIconTests.AnimatedIconPageUITests.Microsoft_UI_Xaml_Controls.ColorPickerTests.ColorPickerSampleUITests.Shared.Windows_UI_Input.GestureRecognizerTests.TransformationsTestsUITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_VisibleBoundsUITests.Shared.Windows_UI_Xaml_Controls.ContentDialogTests.ContentDialog_AsyncUITests.Shared.Windows_UI_Xaml_Controls.ContentDialogTests.ContentDialog_ClosingUITests.Shared.Windows_UI_Xaml_Controls.TextBlockControl.TextBlock_LineHeight_MultipleControlsUITests.Shared.Windows_UI_Xaml_Controls.WebView.WebView_NavigateToString2
-
wasm-automated-net8.0-UWP-Default-automated: 640 changed over 1952🚨🚨 Comparison Details (first 20) 🚨🚨
Border_CornerRadius_BorderThickness_Border-CornerRadius-10-BorderThickness-10_0_0_10Brushes_RadialGradientBrush_MUXControlsTestApp_RadialGradientBrushPageButton_OverlappedButtons_UITests_Shared_Windows_UI_Xaml_Controls_Button_Overlapped_ButtonsDisabled_MenuFlyoutItem_disabledItemDisabled_MenuFlyoutItem_fileMenuFocusManager_GetFocusedElement_ToggleButton_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_AutomatedGrid_Grid_MinWidth_MaxWidth_UITests_Shared_Windows_UI_Xaml_Controls_GridTestsControl_Grid_MinWidth_MaxWidthImage_Invalid_image_invalid_before_hideImage_Invalid_Uno_UI_Samples_UITests_ImageTests_Image_InvalidImage_LargeImageList_Uno_UI_Samples_UITests_LargeImageListInputScope_Should_Not_Validate_Input_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_CurrencyAmountKeyboard_Textbox_InsideScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBoxKeyboard_Textbox_InsideScrollViewer_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_InsideScrollerViewer_AutomatedKeyboard_Textbox_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_InsideScrollerViewer_AutomatedListView_ListViewGroupedVariableHeightComplexTemplate_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedVariableHeightComplexTemplateListView_ListViewHeaderFooterOnly_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooterOnlyListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImageAutoSuggestBox_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Description_UITests_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_DescriptionBitmapImage_vs_SvgImageSource_BitmapRemote_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSourceBorder_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
-
wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net8.0-UWP-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1 -
wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1