uno fix: Do not recycle ImageSource bitmaps on Android

trafficstars

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Validated PR Screenshots Compare Test Run results.
[ ] Contains NO breaking changes
[ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
[ ] Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

Jul 24 '24 15:07 MartinZikmund

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17679/index.html

Jul 24 '24 15:07 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17679/index.html

Jul 24 '24 16:07 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17679/index.html

Oct 17 '24 14:10 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17679/index.html

Oct 17 '24 15:10 unodevops

The build 143948 found UI Test snapshots differences: android-28-net8: 25, android-28-net8-Snap: 50, ios: 7, ios-Snap: 54, skia-gtk-screenshots: 65, skia-linux-screenshots: 65, skia-windows-screenshots: 70, wasm: 438, wasm-automated-net9.0-UWP-Default-automated: 26, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 25 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ContentControl_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Changing_ContentTemplate
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- FocusManager_GetFocusedElement_ScrollViewer_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
- ContentPresenter_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Changing_ContentTemplate
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- FocusManager_GetFocusedElement_ScrollViewer_Validation_FocusManager_-_GetFocusedElement_-_ScrollViewer_-_1_-_Initial_State
- FocusManager_GetFocusedElement_ScrollViewer_Validation_FocusManager_-_GetFocusedElement_-_ScrollViewer_-_2_-_After_Selection
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
android-28-net8-Snap: 50 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Border_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness
- GridView_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- Border_SimplewithNonUnifmormRadius_Uno_UI_Samples_UITests_BorderTestsControl_SimplewithNonUnifmormRadius
- Border_ZeroThickness_Uno_UI_Samples_UITests_BorderTestsControl_ZeroThickness
- TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
- Border_Uniform_Thickness_and_Large_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Large_Radius
- NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage
- NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
- Buttons_CheckBox_IsEnabled_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- Border_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_BorderThickness
- Buttons_ComboBox_Simple_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ComboBox_Simple
- Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Decorations_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Decorations
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Foreground_While_Collapsed_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Foreground_While_Collapsed
ios: 7 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
ios-Snap: 54 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2
- ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
- Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
- GridView_GenericApp_Views_Samples_Shared_Content_UITests_GridViewGrouped_GenericApp_Views_Samples_Shared_Content_UITests_GridViewGrouped
- ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Uno_UI_Samples_UITests_Image_Image_Stretch
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
skia-gtk-screenshots: 65 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- RectanglemaskingRectangleGrid.png
- ImageIconPage.png-dark
- TransformToVisual_Simple.png-dark
- TransformToVisual_Simple.png
- TextBlock_IsTextSelectionEnabled.png-dark
- TextBlock_IsTextSelectionEnabled.png
- DropDownButtonPage.png-dark
- NetworkInformation.png-dark
- NetworkInformation.png
- Path_Geometries.png-dark
- Path_Geometries.png
- DropDownButtonPage.png
- ContentPresenter_NativeEmbedding.png-dark
- ContentPresenter_NativeEmbedding.png
- ImageIconPage.png
- Gamepad_CurrentReading.png-dark
- Ellipse.png
- SplitButtonTestsPage.png-dark
- UIElement_Layout_Bug2879.png-dark
- RepeatButton_Automated.png-dark
skia-linux-screenshots: 65 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- ButtonClippingTestsControl.png-dark
- ContentPresenter_NativeEmbedding.png
- Gamepad_CurrentReading.png-dark
- BorderImageBrush.png-dark
- BorderImageBrush.png
- ImageWithLateSourceUniformToFill.png-dark
- ImageWithLateSourceUniformToFill.png
- Buttons.png
- DropDownButtonPage.png-dark
- Gamepad_Enumeration.png-dark
- BorderImageBrushRelativeTransform.png-dark
- BorderImageBrushRelativeTransform.png
- ClipboardTests.png-dark
- DisplayInformation.png-dark
- ImagesInlineInFlipView.png-dark
- ImagesInlineInFlipView.png
- ClipboardTests.png
- ImageBrushAlignmentXY2.png-dark
- ImageBrushAlignmentXY2.png
- Image_UseTargetSize.png-dark
skia-windows-screenshots: 70 changed over 2220
🚨🚨 Comparison Details (first 20) 🚨🚨
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- BorderImageBrushRelativeTransform.png-dark
- BorderImageBrushRelativeTransform.png
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- BorderImageBrush.png-dark
- Gamepad_CurrentReading.png-dark
- ImageBrush_UniformToFill.png-dark
- ImageBrush_UniformToFill.png
- ImageIconPage.png-dark
- ImageIconPage.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- Buttons.png-dark
- DisplayInformation.png-dark
wasm: 438 changed over 1044
🚨🚨 Comparison Details (first 20) 🚨🚨
- GenericApp.Views.Content.UITests.ImageBrushTestControl.ImageBrush_UniformToFill
- SamplesApp.Samples.UnitTests.HttpUnitTests
- SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Border_With_TranslateTransform
- SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListView_Padding
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderImage
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListView
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Path_Geometry
- UITests.Microsoft_UI_Xaml_Controls.ProgressBar.WinUIProgressBarPage
- UITests.Shared.Windows_Graphics_Display.DisplayInformationTests
- UITests.Shared.Windows_Security_Credentials.PasswordVaultTests.CredentialsPersistence
- UITests.Shared.Windows_UI_Xaml_Controls.BitmapIconTests.BitmapIcon_Foreground
- UITests.Shared.Windows_UI_Xaml_Controls.BitmapIconTests.BitmapIcon_Generic
- UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Aligned_Left
- UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_DataContext_Propagation
- UITests.Shared.Windows_UI_Xaml_Shapes.MeasurePage
- UITests.Shared.Windows_UI_Xaml_Shapes.PathTestsControl.Path_LinearGradientBrush
- UITests.Windows_UI_Xaml.UIElementTests.InlineTextInSpan
- UITests.Windows_UI_Xaml.UIElementTests.UIElement_Alignments
- UITests.Windows_UI_Xaml.UIElementTests.UIElement_BringIntoView_ListView
- UITests.Windows_UI_Xaml_Controls.ImageTests.SvgImageSource_FromMsAppData
wasm-automated-net9.0-UWP-Default-automated: 26 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Default_StrokeThickness_MyLine
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- Default_StrokeThickness_MyPolygon
- Default_StrokeThickness_MyRect
- Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

Oct 21 '24 13:10 nventive-devops

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

Feb 13 '25 02:02 github-actions[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

Apr 22 '25 02:04 github-actions[bot]

Closing for now, as Skia rendering is now preferred

Jun 11 '25 14:06 MartinZikmund

uno uno copied to clipboard

fix: Do not recycle ImageSource bitmaps on Android

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

uno
uno copied to clipboard