uno
uno copied to clipboard
fix: Fix possible exception when implementing custom version of HR attributes
GitHub Issue (If applicable): closes #
Bugfix
Fix possible exception when implementing custom version of HR attributes
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Run
results. - [ ] Contains NO breaking changes
- [ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [x] Commits must be following the Conventional Commits specification.
Other information
Internal Issue (If applicable):
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16722/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16722/index.html
The build 125229 found UI Test snapshots differences: android-28-net8
: 15, android-28-net8-Snap
: 34, ios
: 4, ios-Snap
: 43, skia-gtk-screenshots
: 314, skia-linux-screenshots
: 316, skia-windows-screenshots
: 299, wasm
: 297, wasm-automated-net8.0-UWP-Default-automated
: 35, wasm-automated-net8.0-UWP-RuntimeTests-0
: 0, wasm-automated-net8.0-UWP-RuntimeTests-1
: 0, wasm-automated-net8.0-UWP-RuntimeTests-2
: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated
: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0
: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1
: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2
: 0, android-28-net7
: 0, android-28-net7-Snap
: 0, wasm-automated-net7.0-UWP-Default-automated
: 0, wasm-automated-net7.0-UWP-RuntimeTests-0
: 0, wasm-automated-net7.0-UWP-RuntimeTests-1
: 0, wasm-automated-net7.0-UWP-RuntimeTests-2
: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2
: 0
Details
-
android-28-net8
: 15 changed over 829🚨🚨 Comparison Details (first 20) 🚨🚨
-
Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
-
ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
-
ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
-
When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
-
When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
-
ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
-
NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
-
BasicTest_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage
-
Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
-
ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
-
When_InListView_after_scroll
-
When_InScrollViewer_after_scroll
-
Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
-
-
android-28-net8-Snap
: 34 changed over 1064🚨🚨 Comparison Details (first 20) 🚨🚨
-
Shapes_SamplesApp_Windows_UI_Xaml_Shapes_StretchPage_SamplesApp_Windows_UI_Xaml_Shapes_StretchPage
-
TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
-
MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
-
MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
-
MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
-
Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
-
MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
-
TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
-
ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
-
Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
-
TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewItemsSourceTests_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewItemsSourceTests
-
TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
-
TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewSelectionAndScrolling_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewSelectionAndScrolling
-
WebView_WebView2_Mailto_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Mailto
-
WebView_WebView2_NavigateToUri_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigateToUri
-
WebView_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_AnchorNavigation_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_AnchorNavigation
-
WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic
-
WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync
-
WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties
-
Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
-
-
ios
: 4 changed over 269🚨🚨 Comparison Details (first 20) 🚨🚨
-
SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
-
Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
-
ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
-
ios-Snap
: 43 changed over 1055🚨🚨 Comparison Details (first 20) 🚨🚨
-
Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
-
Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill
-
Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
-
Default_UITests_Toolkit_ElevatedView_Dimensions_UITests_Toolkit_ElevatedView_Dimensions
-
Default_UITests_Toolkit_ElevatedView_Levels_UITests_Toolkit_ElevatedView_Levels
-
Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
-
Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
-
Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
-
NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
-
Microsoft_UI_Xaml_Media_UITests_Windows_UI_Xaml_Media_ThemeShadowTests_ThemeShadow_Basic_UITests_Windows_UI_Xaml_Media_ThemeShadowTests_ThemeShadow_Basic
-
Microsoft_UI_Xaml_Media_UITests_Windows_UI_Xaml_Media_ThemeShadowTests_ThemeShadow_CornerRadius_UITests_Windows_UI_Xaml_Media_ThemeShadowTests_ThemeShadow_CornerRadius
-
Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
-
MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
-
Toolkit_UITests_Toolkit_ElevatedViewTests_UITests_Toolkit_ElevatedViewTests
-
Toolkit_UITests_Toolkit_ElevationView_Clipping_UITests_Toolkit_ElevationView_Clipping
-
Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
-
ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
-
Scrolling_UITests_Microsoft_UI_Xaml_Controls_ScrollViewTests_SimpleScrollViewSample_UITests_Microsoft_UI_Xaml_Controls_ScrollViewTests_SimpleScrollViewSample
-
Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
-
Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_Fallback_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_Fallback
-
-
skia-gtk-screenshots
: 314 changed over 2202🚨🚨 Comparison Details (first 20) 🚨🚨
-
BorderImageBrushRelativeTransform.png
-
ListView_ProportionalPanel.png-dark
-
ListView_ProportionalPanel.png
-
ToggleSwitch_Custom.png-dark
-
ToggleSwitch_Custom.png
-
Border_AntiAlias.png-dark
-
ContentPresenter_Background.png
-
Elevation.png-dark
-
Elevation.png
-
ListViewIncrementalLoading.png-dark
-
ListViewIncrementalLoading.png
-
ScrollViewBringIntoViewPage.png-dark
-
ScrollViewBringIntoViewPage.png
-
TwoPaneView.png-dark
-
TwoPaneView.png
-
BorderImageBrushRelativeTransform.png-dark
-
InfoBadgePage.png-dark
-
CalendarView_Theming.png-dark
-
ComboBox_MaxDropdownHeight.png-dark
-
ComboBox_ScrollViewer.png-dark
-
-
skia-linux-screenshots
: 316 changed over 2202🚨🚨 Comparison Details (first 20) 🚨🚨
-
BasicEnability.png-dark
-
BorderImageBrushRelativeTransform.png
-
Border_AntiAlias.png-dark
-
Border_CornerRadius_Binding.png
-
Border_CornerRadius_BorderThickness.png-dark
-
Border_CornerRadius_BorderThickness.png
-
ElevatedView_CornerRadius.png-dark
-
ElevatedView_CornerRadius.png
-
Basics.png-dark
-
Basics.png
-
BitmapIcon_Foreground.png
-
Border_AntiAlias.png
-
Border_CornerRadius_Gradient.png
-
ContentPresenter_Background.png-dark
-
ContentPresenter_Background.png
-
Elevation.png-dark
-
Elevation.png
-
FrameworkElement_NativeLayout.png-dark
-
FrameworkElement_NativeLayout.png
-
BorderImageBrush.png-dark
-
-
skia-windows-screenshots
: 299 changed over 2202🚨🚨 Comparison Details (first 20) 🚨🚨
-
BitmapIcon_Foreground.png-dark
-
BitmapIcon_Foreground.png
-
Basics.png-dark
-
Border_CornerRadius.png-dark
-
Border_LinearGradientBrush.png
-
Border_CornerRadius_Binding.png-dark
-
Border_CornerRadius_Binding.png
-
Circle.png-dark
-
Border_CornerRadius_BorderThickness.png-dark
-
Circle.png
-
Border_CornerRadius_BorderThickness.png
-
ComboBox_MaxDropdownHeight.png-dark
-
Ellipse_StrokeThickness.png-dark
-
Ellipse_StrokeThickness.png
-
Focus_FocusVisual_Properties.png-dark
-
Focus_FocusVisual_Properties.png
-
Grid_With_RotateTransform_And_Button.png-dark
-
GradientsPage.png-dark
-
Grid_With_RotateTransform_And_Button.png
-
GradientsPage.png
-
-
wasm
: 297 changed over 1042🚨🚨 Comparison Details (first 20) 🚨🚨
-
Benchmarks.Shared.Controls.BenchmarkDotNetTestsPage
-
MUXControlsTestApp.PipsPagerPage
-
MUXControlsTestApp.SwipeControlPage2
-
SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Rectangle_With_RotateTransform
-
SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewChangeHeight
-
SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.AutoSizedTopLeft
-
UITests.Microsoft_UI_Xaml_Controls.ProgressBar.WinUIProgressBarPage
-
UITests.Microsoft_UI_Xaml_Controls.ProgressBar.WinUIProgressBarSimple
-
UITests.Shared.Windows_UI_Xaml.ViusalStateTests.VisualState_AdaptiveTrigger_Storyboard
-
UITests.Shared.Windows_UI_Xaml_Controls.ToolTip.TextOnlyToolTipSample
-
UITests.Shared.Windows_UI_Xaml_Controls.WebView.WebView_Animated_Opacity
-
UITests.Windows_Devices.Midi.MidiDeviceInput
-
UITests.Windows_UI_Xaml_Controls.CommandBar.CommandBar_Native_With_AppBarButton_With_Foreground
-
UITests.Windows_UI_Xaml_Controls.LoopingSelectorTests.LoopingSelector_Short
-
UITests.Windows_UI_Xaml_Controls.SwipeControlTests.SwipeControl_ListView_ItemClick
-
UITests.Windows_UI_Xaml_Controls.TextBlockControl.TextBlock_IsTextSelectionEnabled
-
UITests.Windows_UI_Xaml_Controls.TextBlockControl.TextBlock_LayoutAlignment
-
MUXControlsTestApp.SwipeControlPage
-
SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_ChromeClient
-
SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigateToString
-
-
wasm-automated-net8.0-UWP-Default-automated
: 35 changed over 1963🚨🚨 Comparison Details (first 20) 🚨🚨
-
Check_ListView_Swallows_Measure_after_scroll
-
ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
-
Default_StrokeThickness_MyPolygon
-
Border_OnepxThicknessandRadiusAndTextBlock_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadiusAndTextBlock
-
Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
-
ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
-
Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
-
MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
-
Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
-
MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
-
MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
-
MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
-
TextBlock_TextBlock_Padding_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Padding
-
TextBlock_TextBlock_Run_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Run_Inheritance
-
TextBlock_TextBlock_Span_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Span
-
TextBlock_TextBlock_Style_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Style_Inheritance
-
TextBlock_TextBlock_Nested_Measure_With_Outer_Alignments_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Nested_Measure_With_Outer_Alignments
-
When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
-
When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
-
When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
-
-
wasm-automated-net8.0-UWP-RuntimeTests-0
: 0 changed over 1 -
wasm-automated-net8.0-UWP-RuntimeTests-1
: 0 changed over 1 -
wasm-automated-net8.0-UWP-RuntimeTests-2
: 0 changed over 1 -
wasm-automated-net8.0-WinUI-Benchmarks-automated
: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-0
: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-1
: 0 changed over 1 -
wasm-automated-net8.0-WinUI-RuntimeTests-2
: 0 changed over 1 -
android-28-net7
: 0 changed over 829 -
android-28-net7-Snap
: 0 changed over 1059 -
wasm-automated-net7.0-UWP-Default-automated
: 0 changed over 1958 -
wasm-automated-net7.0-UWP-RuntimeTests-0
: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-1
: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-2
: 0 changed over 1 -
wasm-automated-net7.0-WinUI-Benchmarks-automated
: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-0
: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-1
: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-2
: 0 changed over 1
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
@dr1rrb / @jeromelaban would it be helpful in any way to finalize this PR for the 5.3 release?
@agneszitte no need to backport at this time.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.