uno icon indicating copy to clipboard operation
uno copied to clipboard

fix(visualstates): fix rolling back properties when the next state doesn't modify a property, but modifies one of its subproperties

Open ramezgerges opened this issue 9 months ago • 9 comments

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

ramezgerges avatar May 14 '24 00:05 ramezgerges

cc. @kazo0, this should fix the Toolkit visual states regression.

ramezgerges avatar May 14 '24 00:05 ramezgerges

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16714/index.html

unodevops avatar May 14 '24 00:05 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16714/index.html

unodevops avatar May 14 '24 00:05 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16714/index.html

unodevops avatar May 15 '24 08:05 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16714/index.html

unodevops avatar May 15 '24 09:05 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16714/index.html

unodevops avatar May 15 '24 15:05 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16714/index.html

unodevops avatar May 15 '24 17:05 unodevops

fyi @ramezgerges, this original fix seemed to have fixed https://github.com/unoplatform/uno/issues/14262

So rolling it back might unfix it, maybe?

@eriklimakc maybe check from this branch if the issue happens again

kazo0 avatar May 16 '24 12:05 kazo0

@kazo0 It shouldn't. The title is a bit misleading :). This PR doesn't "roll back" the previous fix, but it fixes a certain scenario where some properties set by animations should not be rolled back (they get rolled back after the other PR when they shouldn't). So it does indeed move some cases to the old behaviour, but it's very unlikely that that was what fixed #14262.

ramezgerges avatar May 16 '24 13:05 ramezgerges

It works fine with the changes from this PR :)

eriklimakc avatar May 17 '24 13:05 eriklimakc