uno icon indicating copy to clipboard operation
uno copied to clipboard

Fix potential github action smells

Open ceddy4395 opened this issue 10 months ago • 8 comments

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

What is the new behavior?

Hey! 🙂 I want to contribute the following changes to your workflow:

  • Stop running workflows when there is a newer commit in branch
  • Use commit hash instead of tags for action versions
  • Use names for run steps
  • Steps should only perform a single command

These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

ceddy4395 avatar Apr 29 '24 14:04 ceddy4395

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 29 '24 14:04 CLAassistant

@ceddy4395 also note we're using conventional commits, you'll need to rewrite your commits using this convention (see the PR template).

jeromelaban avatar Apr 30 '24 13:04 jeromelaban

@jeromelaban, thanks for pointing that out :see_no_evil: I've rewritten the commit messages!

ceddy4395 avatar May 01 '24 07:05 ceddy4395

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html

unodevops avatar May 01 '24 07:05 unodevops

@ceddy4395 it looks like specifying the base path entirely is required:

https://github.com/unoplatform/uno/actions/runs/8906593863/job/24459818384?pr=16508#step:14:49

jeromelaban avatar May 08 '24 11:05 jeromelaban

@jeromelaban Yes I see, thanks for the feedback, I've reverted those changes.

ceddy4395 avatar May 13 '24 08:05 ceddy4395

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html

unodevops avatar May 13 '24 08:05 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html

unodevops avatar May 14 '24 09:05 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html

unodevops avatar May 28 '24 11:05 unodevops

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

welcome[bot] avatar May 28 '24 17:05 welcome[bot]