uno
uno copied to clipboard
Fix potential github action smells
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
- Build or CI related changes
What is the current behavior?
What is the new behavior?
Hey! 🙂 I want to contribute the following changes to your workflow:
- Stop running workflows when there is a newer commit in branch
- Use commit hash instead of tags for action versions
- Use names for run steps
- Steps should only perform a single command
These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Run
results. - [ ] Contains NO breaking changes
- [ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [ ] Commits must be following the Conventional Commits specification.
Other information
Internal Issue (If applicable):
@ceddy4395 also note we're using conventional commits, you'll need to rewrite your commits using this convention (see the PR template).
@jeromelaban, thanks for pointing that out :see_no_evil: I've rewritten the commit messages!
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html
@ceddy4395 it looks like specifying the base path entirely is required:
https://github.com/unoplatform/uno/actions/runs/8906593863/job/24459818384?pr=16508#step:14:49
@jeromelaban Yes I see, thanks for the feedback, I've reverted those changes.
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16508/index.html
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
Merci beaucoup 👋