fix: Fix missing pointer exit on FF when sibling overlaps an overflowing child
closes https://github.com/unoplatform/uno.templates/issues/555
Bugfix
Fix missing pointer exit on FF when sibling overlaps an overflowing child
What is the current behavior?
When we get a pointerout on an element, we are validating if pointer is still above the element in order to discriminate if pointer is effectively leaving the given element, or if it's leaving a child. Currently we are using the list of element that are reported at the current pointer location by the bowser and the parent hierachy of each of those elements.
What is the new behavior?
We are only relying on the parents hierachy between the target and the currentTarget validating bounds of each element itself with and updated condition.
PR Checklist
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Runresults. - [x] Contains NO breaking changes
- [x] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [x] Commits must be following the Conventional Commits specification.
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15433/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15433/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15433/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15433/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15433/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15433/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15433/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15433/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15433/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15433/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15433/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15433/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15433/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15433/index.html
The build 115422 found UI Test snapshots differences: android-28-net7: 18, android-28-net7-Snap: 42, ios: 65, ios-Snap: 734, skia-gtk-screenshots: 829, skia-linux-screenshots: 16, skia-windows-screenshots: 15, wasm: 50, wasm-automated-net7.0-UWP-Default-automated: 32, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0, skia-wpf-screenshots: 0
Details
-
android-28-net7: 18 changed over 819🚨🚨 Comparison Details (first 20) 🚨🚨
Check_ListView_Swallows_Measure_before_scrollDetereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25ListView_ExpandableItem_ExpandMultipleItems_Expanded_StateSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageUpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageWhen_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touchProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220Check_ListView_Swallows_Measure_after_scrollWhen_InListView_after_scrollWhen_Tap_PressedReleasedAreHandled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PointersDetereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_NoneListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Expanded_StateWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewerDecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageWhen_InScrollViewer_after_scroll
-
android-28-net7-Snap: 42 changed over 1051🚨🚨 Comparison Details (first 20) 🚨🚨
Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPageNavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPageMediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_ExtensionMediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_ExtensionMediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_ExtensionProgress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPageProgress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSourcesProgress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_FeaturesImage_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStreamPickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_ThemingToolTip_TextOnlyToolTipSample_UITests_Shared_Windows_UI_Xaml_Controls_ToolTip_TextOnlyToolTipSampleToolTip_ToolTip_CollapsedHost_UITests_Windows_UI_Xaml_Controls_ToolTip_ToolTip_CollapsedHostToolTip_ToolTip_DynamicContent_UITests_Windows_UI_Xaml_Controls_ToolTip_ToolTip_DynamicContentTransform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_BasicsListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_MeasureRatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPageTextBox_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Margin_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_MarginTextBox_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Visibility_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_VisibilityWindows_Media_MediaPlayer_UITests_Windows_Media_MediaPlayerTestsListView_ListViewGrouped_ItemContainerStyleSelector_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped_ItemContainerStyleSelector
-
ios: 65 changed over 265🚨🚨 Comparison Details (first 20) 🚨🚨
Change_Manipulation_Property_Before_property_changeComboBoxTests_Fullscreen_Popup_iOS_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_FullScreen_PopupScreenshots_Image_Stretch_Alignment_Equal_Mode-3When_Navigated_CommandBarDisplayCustomBackButtonIcon_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_BackButtonImage_CommandBar_FrameWhen_Navigated_CommandBarShouldHideBackButtonTitle_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_BackButtonTitle_CommandBar_FrameCheck_CornerRadius_Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_ToggleScreenshots_Image_Stretch_Alignment_Equal_Mode-0ScrollViewer_Clipping_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_ClippingScrollViewer_Content_Margin_After-ScrolledScrollViewer_WhenAsync_RunIdleAndCompletesWithNonIntermediate_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_UpdatesModeComboBoxTests_Stretch_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_StretchCheck_CornerRadius_Border_No_CornerRadiusComboBoxTests_ToggleDisabled_ComboBox_EnabledPivot_Non_PivotItem_Items_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_AutomatedScreenshots_Image_Stretch_Alignment_Wider_Mode-0Screenshots_Image_Stretch_Alignment_Wider_Mode-1When_CustomContentAndLongTitleAndDoubleNavigation_TitleShouldNotOverlapBarButtons_OnNavigateBack_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_LongTitle_CommandBar_FrameWhen_CustomContentAndLongTitle_TitleShouldNotOverlapBarButtons_OnLoad_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_LongTitle_CommandBar_FrameWhen_CustomContentAndLongTitle_TitleShouldNotOverlapBarButtons_OnNavigateBack_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_LongTitle_CommandBar_FrameWhen_CustomContent_CommandBarTitleShouldBeVisible_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_CustomContent_CommandBar_Frame
-
ios-Snap: 734 changed over 1042🚨🚨 Comparison Details (first 20) 🚨🚨
Animations_DoubleAnimation_opacity_final_state_UITests_Windows_UI_Xaml_Media_Animation_DoubleAnimation_FinalState_OpacityAnimations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_FillAutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Keyboard_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_KeyboardBorder_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmarginBorder_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThicknessBorder_SimplewithNonUnifmormRadius_Uno_UI_Samples_UITests_BorderTestsControl_SimplewithNonUnifmormRadiusBrushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGridBrushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfillBrushes_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_Fallback_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_FallbackBrushes_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_Changed_UITests_Windows_UI_Xaml_Media_BrushesTests_SolidColorBrush_Color_ChangedButtons_CheckBox_IsEnabled_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_AutomatedButtons_ComboBox_Simple_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ComboBox_SimpleCanvas_SamplesApp_Windows_UI_Xaml_Controls_Canvas_Measure_Children_In_Canvas_SamplesApp_Windows_UI_Xaml_Controls_Canvas_Measure_Children_In_CanvasCheckBox_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_AutomatedComboBox_ComboBox_CornerRadius_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_CornerRadiusComboBox_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_FullScreen_Popup_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_FullScreen_PopupComboBox_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Header_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_HeaderContentPresenter_ContentPresenter_Content_DataContext_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Content_DataContextContentPresenter_ContentPresenter_ImplicitContent_UITests_Shared_Windows_UI_Xaml_Controls_ContentPresenter_ContentPresenter_ImplicitContentDefault_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Foreground_Changing_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Foreground_Changing
-
skia-gtk-screenshots: 829 changed over 1114🚨🚨 Comparison Details (first 20) 🚨🚨
Animations-ColorAnimationUsingKeyFrames_Fill.pngAutoSuggestBox-BasicAutoSuggestBox.pngBrushes-ImageBrush_Stretch.pngButtons-HyperlinkButton_IsEnabled_Automated.pngClipping-UIElement_Clipping.pngContentControl-ContentControl_Nested_TemplatedParent.pngContentControl-ContentControl_SelectorInheritance.pngFocus-GetFocus.pngFrameworkElement-FrameworkElement_NativeLayout.pngIcons-BitmapIcon_Foreground.pngIcons-BitmapIcon_Sizing.pngListView-ListViewLargeHeader.pngListView-ListView_WithScrollViewer.pngListView-SwipeControl_ListView_ItemClick.pngNavigationView-NavigationViewStretchPage.pngNavigationView-NavigationViewTopNavPage.pngShapes-LineStretchModes.pngShapes-Offscreen_Shapes.pngShapes-PathStretchModes.pngToggleSwitch-Native_ToggleSwitch_IsOn.png
-
skia-linux-screenshots: 16 changed over 1114🚨🚨 Comparison Details (first 20) 🚨🚨
Microsoft.UI.Composition-RedirectVisual.pngMUX-WinUIProgressRingPage.pngMUX-WinUIProgressRing_CustomSources.pngProgress-ProgressRingHeightTest.pngProgress-WindowsProgressRing_GH1220.pngProgress-WinUIProgressRingPage.pngProgress-WinUIProgressRing_CustomSources.pngImage-UniformToFill100x100.pngPipsPager-PipsPagerExamples.pngTransform-TransformToVisual_Translate2d.pngListView-ListViewSelectedItems.pngProgress-WinUIProgressRing_Features.pngMicrosoft.UI.Composition-CompositionEffectBrush.pngMicrosoft.UI.Composition-CompositionMaskBrush.pngMicrosoft.UI.Composition-CompositionVisualSurface.pngWinUI-PipsPagerExamples.png
-
skia-windows-screenshots: 15 changed over 1114🚨🚨 Comparison Details (first 20) 🚨🚨
Image-ImageSourceStream.pngListView-ListViewSelectedItems.pngPipsPager-PipsPagerExamples.pngMUX-WinUIProgressRingPage.pngMUX-WinUIProgressRing_CustomSources.pngMicrosoft.UI.Composition-CompositionMaskBrush.pngMicrosoft.UI.Composition-CompositionVisualSurface.pngProgress-WinUIProgressRingPage.pngProgress-WinUIProgressRing_CustomSources.pngProgress-ProgressRingHeightTest.pngProgress-WindowsProgressRing_GH1220.pngMicrosoft.UI.Composition-RedirectVisual.pngProgress-WinUIProgressRing_Features.pngAutomation-AutomationProperties_Name.pngWinUI-PipsPagerExamples.png
-
wasm: 50 changed over 1047🚨🚨 Comparison Details (first 20) 🚨🚨
MUXControlsTestApp.NavigationViewStretchPageSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewerUITests.Shared.Microsoft_UI_Xaml_Controls.TwoPaneViewTests.TwoPaneViewPageUITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DropDownPlacementUITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_3gp_ExtensionSamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelectedUITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_FeaturesUITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_VerticalUITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Stretch_FillUITests.Windows_UI_Xaml_Media.ImageBrushTests.ImageBrush_FormatsUITests.Windows_Media.MediaPlayerTestsMUXControlsTestApp.NavigationViewItemTemplatePageSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGrouped_ItemContainerStyleSelectorUITests.Microsoft_UI_Xaml_Controls.NumberBoxTests.NumberBox_HeaderUITests.Windows_UI_Xaml_Media_Animation.ColorAnimation_BackgroundUITests.Windows_UI_Xaml_Media_Animation.ColorAnimation_FillMUXControlsTestApp.NavigationViewMenuItemStretchPageSamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListViewUno.UI.Samples.Content.UITests.CommandBar.CommandBar_NativeUno.UI.Samples.Content.UITests.CommandBar.CommandBar_With_Long_Sentences
-
wasm-automated-net7.0-UWP-Default-automated: 32 changed over 1949🚨🚨 Comparison Details (first 20) 🚨🚨
Default_StrokeThickness_MyPolygonCheck_ListView_Swallows_Measure_after_scrollMediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_FillMediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalMediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_SourcesDefault_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelectedFocusManager_GetFocusedElement_ListViewItem_Validation_FocusManager_-_GetFocusedElement_-_ListViewItem_-_2_-_After_SelectionListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsPickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_ThemingListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageProgress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPageProgress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSourcesProgress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_FeaturesPipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamplesSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageWhen_Reorder_SelectedItem_Down_Item_2_SelectedWhen_Reorder_SelectedItem_Up_Item_5_SelectedWhen_Theme_Changed_No_Crash_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
-
wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1 -
wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1 -
skia-wpf-screenshots: 0 changed over 1114