uno.toolkit.ui icon indicating copy to clipboard operation
uno.toolkit.ui copied to clipboard

[Fluent] `NavigationBar` is not themed

Open MartinZikmund opened this issue 1 year ago • 4 comments

Current behavior

In light theme it looks like this (ok)

image

In dark theme it looks like this (not ok)

image

Same for the three dots button:

threedots

Expected behavior

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • [ ] iOS
  • [ ] Android
  • [ ] WebAssembly
  • [ ] WebAssembly renders for Xamarin.Forms
  • [ ] Windows
  • [ ] Build tasks

Visual Studio:

  • [ ] 2017 (version: )
  • [ ] 2019 (version: )
  • [ ] for Mac (version: )

Relevant plugins:

  • [ ] Resharper (version: )

Anything else we need to know?

MartinZikmund avatar Apr 09 '23 11:04 MartinZikmund

@MartinZikmund which platform is this on? I'm seeing this working fine on Windows and WASM eg image

nickrandolph avatar Apr 11 '23 02:04 nickrandolph

This was happening on WASM and Windows. I am guessing that it was duetl to the fact that I used Fluent instead of Material - the template may be different

MartinZikmund avatar Apr 11 '23 10:04 MartinZikmund

cc @kazo0 I think this is an issue with the fluent navigationbar styling not set to handle theming correctly

nickrandolph avatar Apr 12 '23 05:04 nickrandolph

Yeah the Toolkit controls really don't have a lot of love given to the non-Material styles at this point so we're going to need to take time to see how these should look in a non-Material context

kazo0 avatar Apr 12 '23 16:04 kazo0