uno.templates icon indicating copy to clipboard operation
uno.templates copied to clipboard

`TargetFrameworks` should be better as a single line

Open Youssef1313 opened this issue 10 months ago • 1 comments

image

If someone decided to do <CompilerVisibleProperty Include="TargetFrameworks" /> for some reason, the multi-line will break Roslyn. The way compiler-visible properties are passed to the compiler is by generating an .editorconfig file. But Roslyn will not handle this case properly (known limitation).

NOTE: I know it's not common at all that someone makes TargetFrameworks a compiler-visible property (usually people would care about TargetFramework). But if someone decided to do it. It will break badly.

Youssef1313 avatar Apr 23 '24 18:04 Youssef1313

I agree. It's causing more trouble than the readability it improves.

jeromelaban avatar Apr 24 '24 11:04 jeromelaban

Does this mean updating all the samples migrated and in migration process to use single line tfms?

cc @agneszitte @jeromelaban

eriklimakc avatar May 17 '24 12:05 eriklimakc

@eriklimakc yes it would be good to update the samples to use a single line for the tfms

dansiegel avatar May 17 '24 12:05 dansiegel