uno.extensions icon indicating copy to clipboard operation
uno.extensions copied to clipboard

Published 20 hours ago • verified publisher icon unoplatform

chore: Update Overview.md

Open sherifelantil opened this issue 2 years ago • 2 comments

Replaced the MVUX model class name "WeatherModel" with "MainModel" to be consistent with the code description.

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

The MVUX code sample included a typo where the Model class was named "WeatherModel" while it was called "MainModel" in the rest of the document.

What is the new behavior?

The MVUX code sample is now consistent with the rest of the document.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tested code with current supported SDKs
  • [X] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [ ] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • [ ] Contains NO breaking changes
  • [ ] Updated the Release Notes
  • [ ] Associated with an issue (GitHub or internal)

Other information

sherifelantil avatar Sep 26 '23 12:09 sherifelantil

@sherifelantil are you able to address the conventional commits fail by updating the comment for your commit

nickrandolph avatar Oct 11 '23 07:10 nickrandolph

@sherifelantil can you change the mesasage on your commit to start with "chore: " so we can merge this PR

nickrandolph avatar Nov 17 '23 09:11 nickrandolph